Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add explicit string-width resolution to fix ESM + CJS compat issue #20197

Closed
wants to merge 1 commit into from

Conversation

LaurentGoderre
Copy link
Contributor

@LaurentGoderre LaurentGoderre commented May 13, 2024

Fixes #20065

Got some code for us? Awesome 馃帄!

Please include a description of your change & check your PR against this list, thanks!

  • There's a clear use-case for this code change, explained below
  • Commit message has a short title & references relevant issues
  • The build will pass (run yarn test:all and yarn lint)

We appreciate your contribution!

@daniellockyer daniellockyer self-requested a review May 13, 2024 16:30
Copy link
Member

@daniellockyer daniellockyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Won't this set all string-width to the same version? We have like 3 or 4 different majors in the codebase atm and I'm concerned there are breaking changes between them (I've not checked yet)

Also, you'll need to re-run yarn from the top-level in order to pick this up in yarn.lock

@daniellockyer
Copy link
Member

Hmm, it might also need adding to ghost/core/package.json. Perhaps this is why the previous fix didn't work 馃

daniellockyer pushed a commit that referenced this pull request May 15, 2024
)

refs #20197

- adds a jackspeak resolution to Ghost core so we can try and ensure the compatible version of jackspeak/string-width is used when the lockfile is regenerated
@LaurentGoderre
Copy link
Contributor Author

Jackspeak in core wasn't enough either: https://github.com/docker-library/ghost/actions/runs/9113251164/job/25054334936

@daniellockyer
Copy link
Member

The commit wasn't shipped in v5.82.10. We'll need to wait until tomorrow's release for that

@LaurentGoderre
Copy link
Contributor Author

@daniellockyer really? Here's what I saw

Screenshot 2024-05-16 at 9 52 23鈥疉M

@daniellockyer
Copy link
Member

@LaurentGoderre GitHub doesn't show the correct history flow. That release was done from a branch of v5.82.9 with one commit applied on top

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Outdated version of string-width is causing the Docker image entrypoint loading to fail.
2 participants