Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: remove ingest tests job from CI workflow #340

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

scanny
Copy link
Contributor

@scanny scanny commented Apr 23, 2024

Summary
These ingests tests have been failing for a while now and were not required for merge. As we have no immediate intention of fixing these and their value in this context is doubtful, remove them.

These ingests tests have been failing for a while now and were not
required for merge. As we have no immediate intention of fixing these
and their value in this context is doubtful, remove them.
@scanny scanny requested a review from qued April 23, 2024 01:26
@amadeusz-ds
Copy link

amadeusz-ds commented May 21, 2024

If we're merging PRs even though it's failing for me it means we can remove it.
@qued ?

@amadeusz-ds amadeusz-ds self-requested a review May 21, 2024 09:29
Copy link

@amadeusz-ds amadeusz-ds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@scanny
Copy link
Contributor Author

scanny commented May 21, 2024

@amadeusz-ds I believe Crag was inclined for us to try to fix these rather than remove them.

@amadeusz-ds
Copy link

@amadeusz-ds I believe Crag was inclined for us to try to fix these rather than remove them.

Anyone looked into this? I could work on that, but I don't see anything in the logs that might point to the source of the problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants