Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Utils] Add script for building ggml plugin on ubuntu and manylinux2014 #3116

Closed
wants to merge 1 commit into from

Conversation

hydai
Copy link
Member

@hydai hydai commented Dec 26, 2023

No description provided.

@hydai hydai requested a review from dm4 December 26, 2023 05:13
Copy link
Member

juntao commented Dec 26, 2023

Hello, I am a code review bot on flows.network. Here are my reviews of code commits in this PR.


Commit 3d543eaa137d2b2ca89f7bbc5ddbc377a2506822

The main changes in this patch are about supporting the build for a Ggml plugin on a Linux machine. This patch is adding two new scripts: build_ggml_plugin.sh and install_cuda_12.2.sh.

  1. build_ggml_plugin.sh: This is a script for building the Ggml plugin. It's taking several command line options defining various build parameters (such as the output folder, build number, version, and the distribution architecture). It also allows to build on Ubuntu, enable OpenBLAS, and enable cuBLAS. The script checks if all necessary options are set, and if yes, sets several others and conducts the plugin build process.

  2. install_cuda_12.2.sh: This script installs the CUDA Toolkit 12.2 on a machine. It downloads and installs the CUDA GPG key package and then proceeds with installing the CUDA Toolkit itself.

Potential issues and things to consider:

  1. In build_ggml_plugin.sh, every command line option seems to expect an argument due to the ":" (colon) before every option character in the OPTSTRING. This might result in undesired behavior for options that often are rather seen as flags and don't take an argument (like the u, o, and c options).

  2. Error handling: The scripts do not handle errors that might occur during the execution, for example if a package installation fails. This might lead to a failure in the workflow.

  3. Compatibility: It seems like the scripts are primarily designed for Ubuntu distributions. Make sure they're compatible with other Linux distributions too, if they're going to be used on such.

  4. The scripts are hard-coded to specific versions, such as CUDA 12.2. This may need to be updated or generalized for other versions of those components.

  5. Finally, uncommented code can create maintenance challenges in the long run. Adding comments to describe the functionality and purpose of blocks of code can aid in readability, debugging, and future development.

@hydai hydai force-pushed the hydai/add_build_script_for_ggml_plugin branch 2 times, most recently from 0854b36 to 17c01a4 Compare December 26, 2023 05:36
@github-actions github-actions bot added the c-CI label Dec 26, 2023
@hydai hydai force-pushed the hydai/add_build_script_for_ggml_plugin branch from 6ddbd4b to 3d543ea Compare December 26, 2023 08:47
@github-actions github-actions bot removed the c-CI label Dec 26, 2023
@hydai hydai added the v-0.14.0 label Feb 23, 2024
@hydai
Copy link
Member Author

hydai commented May 29, 2024

Since we are going to use some self-hosted runners to build the assets, we no longer need to add the related scripts and workflows to this repo. Closing it.

@hydai hydai closed this May 29, 2024
@hydai hydai deleted the hydai/add_build_script_for_ggml_plugin branch June 3, 2024 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants