Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump actions/cache from 3 to 4 #3166

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jan 22, 2024

Bumps actions/cache from 3 to 4.

Release notes

Sourced from actions/cache's releases.

v4.0.0

What's Changed

New Contributors

Full Changelog: actions/cache@v3...v4.0.0

v3.3.3

What's Changed

New Contributors

Full Changelog: actions/cache@v3...v3.3.3

v3.3.2

What's Changed

New Contributors

Full Changelog: actions/cache@v3...v3.3.2

v3.3.1

What's Changed

Full Changelog: actions/cache@v3...v3.3.1

v3.3.0

What's Changed

... (truncated)

Changelog

Sourced from actions/cache's changelog.

Releases

3.0.0

  • Updated minimum runner version support from node 12 -> node 16

3.0.1

  • Added support for caching from GHES 3.5.
  • Fixed download issue for files > 2GB during restore.

3.0.2

  • Added support for dynamic cache size cap on GHES.

3.0.3

  • Fixed avoiding empty cache save when no files are available for caching. (issue)

3.0.4

  • Fixed tar creation error while trying to create tar with path as ~/ home folder on ubuntu-latest. (issue)

3.0.5

  • Removed error handling by consuming actions/cache 3.0 toolkit, Now cache server error handling will be done by toolkit. (PR)

3.0.6

  • Fixed #809 - zstd -d: no such file or directory error
  • Fixed #833 - cache doesn't work with github workspace directory

3.0.7

  • Fixed #810 - download stuck issue. A new timeout is introduced in the download process to abort the download if it gets stuck and doesn't finish within an hour.

3.0.8

  • Fix zstd not working for windows on gnu tar in issues #888 and #891.
  • Allowing users to provide a custom timeout as input for aborting download of a cache segment using an environment variable SEGMENT_DOWNLOAD_TIMEOUT_MINS. Default is 60 minutes.

3.0.9

  • Enhanced the warning message for cache unavailablity in case of GHES.

3.0.10

  • Fix a bug with sorting inputs.
  • Update definition for restore-keys in README.md

... (truncated)

Commits

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Note
Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

@dependabot dependabot bot requested a review from hydai as a code owner January 22, 2024 13:41
@dependabot dependabot bot added dependencies Pull requests that update a dependency file github_actions Pull requests that update GitHub Actions code labels Jan 22, 2024
Copy link
Member

juntao commented Jan 22, 2024

Hello, I am a code review bot on flows.network. Here are my reviews of code commits in this PR.


Commit 3d001a1c5527aaf361689f691ade4eba15fc0396

This Pull Request (PR) primarily updates the version of actions/cache used in the GitHub Actions workflow files from version 3 to version 4. actions/cache is a tool for caching dependencies and build outputs to improve workflow execution time.

Key Changes:

  1. The usage of actions/cache is updated in two workflows: build_for_openwrt.yml and reusable-build-extensions-on-manylinux.yml.

  2. In build_for_openwrt.yml, the update is applied in two places. This is both when the OpenWrt cache is restored and saved.

  3. In reusable-build-extensions-on-manylinux.yml, the update is applied in four places. This changes occur when caching the build outputs in the 'cache' steps and when restoring the caches in the 'restore' steps.

Potential issues:

  1. Major version upgrades usually bring in breaking changes. Therefore, it is necessary to review the changes between version 3 and version 4 of actions/cache before merging the PR. The PR has correctly linked the relevant notes and changes, but these need to be reviewed carefully.

  2. The changes in the PR seem to have been auto-generated by Dependabot. While Dependabot is generally reliable, these changes should be manually reviewed and, if possible, tested in a test environment.

  3. All areas where actions/cache is used might not be covered. There is a need to check all action workflows to ensure actions/cache is updated everywhere.

  4. This PR does not provide any context for the reason behind the version bump nor any expected improvements or features. It would be ideal if the requester provided such information which could help understand the necessity, risks, and benefits of the version update.

@github-actions github-actions bot added the c-CI label Jan 22, 2024
@dependabot dependabot bot force-pushed the dependabot/github_actions/actions/cache-4 branch from c26ada0 to 43753a0 Compare January 25, 2024 09:45
@hydai
Copy link
Member

hydai commented Jan 25, 2024

@dependabot close
Due to centos 7 doesn't provide node20, it's no reason to upgrade this dependency.

@dependabot dependabot bot closed this Jan 25, 2024
@dependabot dependabot bot deleted the dependabot/github_actions/actions/cache-4 branch January 25, 2024 10:07
@hydai
Copy link
Member

hydai commented Jan 25, 2024

@dependabot reopen

@dependabot dependabot bot reopened this Jan 25, 2024
@dependabot dependabot bot restored the dependabot/github_actions/actions/cache-4 branch January 25, 2024 10:08
Copy link
Member

@hydai hydai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the manylinux2014 doesn't fit the minimum requirement of this action, we will pause to merge this one unless we drop the manylinux2014 support.

@dependabot dependabot bot force-pushed the dependabot/github_actions/actions/cache-4 branch 2 times, most recently from fd94bb2 to 4a529b0 Compare January 31, 2024 07:38
@dependabot dependabot bot force-pushed the dependabot/github_actions/actions/cache-4 branch 2 times, most recently from 2c40510 to 5b1ed76 Compare February 5, 2024 19:11
@dependabot dependabot bot force-pushed the dependabot/github_actions/actions/cache-4 branch 2 times, most recently from b0247eb to e547fe3 Compare February 14, 2024 09:09
Bumps [actions/cache](https://github.com/actions/cache) from 3 to 4.
- [Release notes](https://github.com/actions/cache/releases)
- [Changelog](https://github.com/actions/cache/blob/main/RELEASES.md)
- [Commits](actions/cache@v3...v4)

---
updated-dependencies:
- dependency-name: actions/cache
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/github_actions/actions/cache-4 branch from e547fe3 to 3d001a1 Compare February 14, 2024 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c-CI dependencies Pull requests that update a dependency file github_actions Pull requests that update GitHub Actions code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants