Cap texture multisampling SampleCount #1670
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also, I guess it might be cleaner if I part out the GL_MAX_SAMPLES stuff into its own function and we just call that to initialize SampleCount. |
FireNX70
changed the title
|
Didn't think of that, thanks a lot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem description
https://gitlab.freedesktop.org/mesa/mesa/-/issues/11135
It turns out LLVMpipe only supports 4x multisampling. Checking GL_MAX_SAMPLES seems like the right thing to do.
Implementation description
Right now, I only check GL_MAX_SAMPLES. Depending on the format, we might need to check GL_MAX_INTEGER_SAMPLES. I don't know how likely it is that you might want to use a different format in the future, glGetInternalformativ might be a safer option to retrieve the max number of samples we can use.Ended up implementing it with glGetInternalformativ.
Additional things
I guess I could merge the
ifs at lines 95, 99 and 103 in imgui_imhex_extensions.cpp while we're at it.