Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨Source Mailgun: Make Connector Compatible with Builder #38176

Merged
merged 8 commits into from
May 28, 2024

Conversation

pabloescoder
Copy link
Collaborator

What

Makes the connector compatible with the Builder UI

How

  • Bump minor version
  • Use Inline Spec
  • Remove $parameters
  • Make it compatible with the Builder

User Impact

Non impacting, done for maintainability

Can this PR be safely reverted and rolled back?

  • YES 💚

Copy link

vercel bot commented May 14, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 28, 2024 7:12pm

@pabloescoder
Copy link
Collaborator Author

The Basic HTTP Authenticator in the Builder needs the username and password field values to be of the form {{ config[key] }} so I added a new config key called username_do_not_edit with the default value api for the username. (It didn't allow me to hardcode the value api)

@octavia-squidington-iv octavia-squidington-iv requested a review from a team May 22, 2024 21:43
@pabloescoder
Copy link
Collaborator Author

@girarda I've defaulted the username to api and removed the extra config value. CI is green.

@girarda girarda merged commit 44dea5a into master May 28, 2024
31 checks passed
@girarda girarda deleted the source-mailgun-make-builder-compatible branch May 28, 2024 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/mailgun
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants