Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨Source Ip2Whois: Make Connector Compatible with Builder #38215

Merged
merged 5 commits into from
May 21, 2024
Merged

✨Source Ip2Whois: Make Connector Compatible with Builder #38215

merged 5 commits into from
May 21, 2024

Conversation

btkcodedev
Copy link
Collaborator

What

  • Make the connector compatible with the builder

How

  • Import schema to manifest
  • Update docs,
  • Completely made compatible with the builder

User Impact

  • No impact, chore for maintainability.

Can this PR be safely reverted and rolled back?

  • YES 💚

@vercel Vercel
Copy link

vercel bot commented May 15, 2024 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 21, 2024 0:51am

@octavia-squidington-iv octavia-squidington-iv requested review from a team May 15, 2024 13:07
@octavia-squidington-iii octavia-squidington-iii added area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/ip2whois labels May 15, 2024
@btkcodedev btkcodedev self-assigned this May 15, 2024
@btkcodedev btkcodedev requested a review from girarda May 15, 2024 14:27
@btkcodedev
Copy link
Collaborator Author

Removed $parameters macro ✅
Embedded Spec ✅

GitHub CI green ✅
Ready to merge

@girarda girarda merged commit 5e80847 into master May 21, 2024
30 checks passed
@girarda girarda deleted the btkcodedev/ipwhoisCompatable branch May 21, 2024 01:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@girarda girarda girarda approved these changes

Assignees

@btkcodedev btkcodedev

Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/ip2whois
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@btkcodedev @girarda @octavia-squidington-iii