Added attributes to svg.Startview and svg.StartviewUnit #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
StartRaw was meant to handle the arbitrary case. |
|
Hmm. ok. Start, Startunit and Startpercent already have the extra attributes. I feel that all of them should have them (no harm since the attributes param is optional), otherwise it feels a little bit inconsistent. But feel free to close this PR if you think different :) |
|
@countcb you are right, it is inconsistent, and my (probably) lame attempt at a general solution was StartRaw. thinking... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added attributes to svg.Startview and svg.StartviewUnit
Was wondering why these two methods had no way of adding attributes like the others.
I hope the changes are ok. If not I can change some things or you can deny the pull request :)