Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(core): Remove legacy_dispatcher.ts which is no longer needed. #55784

Closed
wants to merge 3 commits into from
Closed

refactor(core): Remove legacy_dispatcher.ts which is no longer needed. #55784

wants to merge 3 commits into from

Conversation

tbondwilkinson
Copy link
Contributor

Also use dispatchDelegate by default for eventReplayer.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

@tbondwilkinson
Copy link
Contributor Author

Caretaker note: cl/633635883 necessary to fix internal BUILD rule

@tbondwilkinson tbondwilkinson added the merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note label May 14, 2024
@tbondwilkinson
Copy link
Contributor Author

TESTED=TGP

@tbondwilkinson tbondwilkinson marked this pull request as ready for review May 15, 2024 18:52
@pullapprove pullapprove bot requested review from atscott and csmick May 15, 2024 18:52
@pullapprove pullapprove bot added the requires: TGP This PR requires a passing TGP before merging is allowed label May 15, 2024
@tbondwilkinson tbondwilkinson added action: review The PR is still awaiting reviews from at least one requested reviewer core: event dispatch area: core Issues related to the framework runtime and removed requires: TGP This PR requires a passing TGP before merging is allowed labels May 15, 2024
@ngbot ngbot bot added this to the Backlog milestone May 15, 2024
@tbondwilkinson tbondwilkinson added the requires: TGP This PR requires a passing TGP before merging is allowed label May 15, 2024
@pullapprove pullapprove bot removed the area: core Issues related to the framework runtime label May 15, 2024
@ngbot ngbot bot removed this from the Backlog milestone May 15, 2024
@pullapprove pullapprove bot added the area: core Issues related to the framework runtime label May 15, 2024
@tbondwilkinson tbondwilkinson added target: rc This PR is targeted for the next release-candidate and removed area: core Issues related to the framework runtime labels May 15, 2024
@tbondwilkinson tbondwilkinson requested review from rahatarmanahmed and removed request for csmick May 15, 2024 18:58
AndrewKushnir
AndrewKushnir approved these changes May 17, 2024
View reviewed changes
Copy link
Contributor

@AndrewKushnir AndrewKushnir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (only 1 minor non-blocking proposal) 👍

packages/core/primitives/event-dispatch/src/dispatcher.ts Outdated Show resolved Hide resolved
@tbondwilkinson tbondwilkinson removed the request for review from atscott May 17, 2024 19:32
@tbondwilkinson tbondwilkinson removed the action: review The PR is still awaiting reviews from at least one requested reviewer label May 17, 2024
@tbondwilkinson tbondwilkinson added the action: merge The PR is ready for merge by the caretaker label May 17, 2024
@dylhunn
Copy link
Contributor

dylhunn commented May 21, 2024

This PR was merged into the repository by commit 834e627.

dylhunn pushed a commit that referenced this pull request May 21, 2024
@tbondwilkinson @dylhunn
refactor(core): Remove legacy_dispatcher.ts which is no longer needed. (
e923a76 
#55784)

Also use `dispatchDelegate` by default for `eventReplayer`.

PR Close #55784
@dylhunn dylhunn closed this in 834e627 May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rahatarmanahmed rahatarmanahmed rahatarmanahmed approved these changes

@AndrewKushnir AndrewKushnir AndrewKushnir approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker core: event dispatch merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note requires: TGP This PR requires a passing TGP before merging is allowed target: rc This PR is targeted for the next release-candidate
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@tbondwilkinson @dylhunn @rahatarmanahmed @AndrewKushnir