Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ListItem.tsx #48780

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Update ListItem.tsx #48780

wants to merge 3 commits into from

Conversation

97thjingba
Copy link

@97thjingba 97thjingba commented May 6, 2024

中文版模板 / Chinese template

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English
🇨🇳 Chinese upload组件添加showDownloadIcon 被传入的disabled受控

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

Signed-off-by: lgy <1079937489@qq.com>
Copy link

stackblitz bot commented May 6, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link
Contributor

github-actions bot commented May 6, 2024

Preview is ready

Copy link
Contributor

github-actions bot commented May 6, 2024

  • 🚨 Please fill changelog in the PR

    • Write with a developer-oriented perspective and narrative method, without describing the details of the repair
    • Describing the problem and the impact on the developer
    • describing the user-first site problem, not your solution
    • Refer: https://ant.design/changelog#501
  • 🚨 请填写 PR 中的 changelog

    • 请用面向开发者的角度叙述方式撰写,不描述修复细节
    • 描述问题和对开发者的影响
    • 描述用户第一现场的问题,而非你的解决方式
    • 参考:https://ant.design/changelog-cn#501

Copy link
Contributor

github-actions bot commented May 6, 2024

👁 Visual Regression Report for PR #48780 Passed ✅

🎯 Target branch: master (ddf7028)
📖 View Full Report ↗︎

🎊 Congrats! No visual-regression diff found.

Copy link

codesandbox-ci bot commented May 6, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

修改测试问题

Signed-off-by: lgy <1079937489@qq.com>
@yoyo837
Copy link
Contributor

yoyo837 commented May 6, 2024

请完善一下PR说明和title, 填写一下改动背景。

@afc163
Copy link
Member

afc163 commented May 6, 2024

提供问题重现。

@97thjingba
Copy link
Author

image
很奇怪的一个场景. 从上层数据加载下来以后. 出现了这个情况. 这里截图没办法把禁用的手势截出来。
鼠标放上去这里是一个禁用的状态
我怀疑是 disabled 影响到了这里。但我的业务逻辑里面并没有带disabled
这是我自己的封装的组件. 外层是放在了 antdPro Table 里面的 columns
image

@97thjingba
Copy link
Author

抱歉.实在不知道如何在沙箱里面复现这个问题

@97thjingba
Copy link
Author

我阅读了源码以后在这里 添加 true . 让downloadIcon 的disabled 和 外部传入的props.disabled 保持一致.可以解决这个问题.
@afc163 @yoyo837

Copy link

codecov bot commented May 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (ddf7028) to head (987064d).

Additional details and impacted files
@@            Coverage Diff            @@
##            master    #48780   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          746       746           
  Lines        12994     12994           
  Branches      3411      3411           
=========================================
  Hits         12994     12994           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants