Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove checks for project_id in load_auth() #468

Closed
wants to merge 1 commit into from
Closed

Remove checks for project_id in load_auth() #468

wants to merge 1 commit into from

Conversation

ushuz
Copy link

@ushuz ushuz commented Apr 19, 2024 •
edited

AnthropicVertex accepts project_id from the caller. So whether load_auth() could load the project_id from the Google credential should not be a hard requirement.

Right now, if load_auth() can't load the project_id, it raises ValueError and aborts any further execution.

@ushuz ushuz requested a review from a team as a code owner April 19, 2024 02:33
This was referenced Apr 19, 2024
Merged
Open
@RobertCraigie RobertCraigie self-requested a review May 21, 2024 16:32
@RobertCraigie RobertCraigie mentioned this pull request May 22, 2024
Merged
@RobertCraigie
Copy link
Collaborator

Hey @ushuz, sorry for the delay in getting to this & thanks for the PR! I've merged a separate change which addresses this issue: #513

@RobertCraigie RobertCraigie removed their request for review May 22, 2024 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ushuz @RobertCraigie