Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

draft: 添加G2 中Table的mark #6088

Draft
wants to merge 7 commits into
base: v5
Choose a base branch
from
Draft

draft: 添加G2 中Table的mark #6088

wants to merge 7 commits into from
+297 −0

Conversation

kun6696
Copy link
Contributor

@kun6696 kun6696 commented Feb 21, 2024

Checklist
  • npm test passes
  • [] benchmarks are included
  • commit message follows commit guidelines
  • documents are updated
Description of change

@kun6696 kun6696 changed the title feat: 添加G2 中Table的mark draft: 添加G2 中Table的mark Feb 21, 2024
@pearmini pearmini marked this pull request as draft February 21, 2024 12:08
@pearmini pearmini self-requested a review February 21, 2024 12:10
pearmini
pearmini requested changes Feb 21, 2024
View reviewed changes
__tests__/plots/static/car3-table.ts Outdated Show resolved Hide resolved
@kun6696
Copy link
Contributor Author

kun6696 commented Feb 23, 2024

2024-02-23 16 50 15
这里按照scrollbar 配置 ratio:range。首次展示的正确，翻页的时候，出现错乱的情况 @pearmini

@pearmini
Copy link
Member

@kun6696 这个应该是离散 slider 的一个 bug，我下周看看能不能修复

@kun6696
Copy link
Contributor Author

kun6696 commented Mar 4, 2024

@kun6696 This should be a bug in the discrete slider. I’ll see if it can be fixed next week.

Is there any repair?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pearmini pearmini pearmini requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kun6696 @pearmini