Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(interaction.tooltip): add crosshairs, crosshairsX, crosshairsY setting #6229

Merged
merged 11 commits into from
May 22, 2024
Merged

feat(interaction.tooltip): add crosshairs, crosshairsX, crosshairsY setting #6229

merged 11 commits into from
May 22, 2024

Conversation

Runtus
Copy link
Contributor

@Runtus Runtus commented May 12, 2024 •
edited

Checklist
  • npm test passes
  • benchmarks are included
  • commit message follows commit guidelines
  • documents are updated
Description of change
  • 增加十字辅助线的设置，并增加了crosshairsX, crosshairsY配置接口。

closed: #6092

image image

@coveralls
Copy link

coveralls commented May 12, 2024 •
edited

Pull Request Test Coverage Report for Build 9178125977

Details

  • 54 of 58 (93.1%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 86.392%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/interaction/tooltip.ts 54 58 93.1%
Totals Coverage Status
Change from base Build 9018606304: 0.02%
Covered Lines: 10370
Relevant Lines: 11627
💛 - Coveralls

@pearmini
Copy link
Member

非常优秀！🚀

@pearmini pearmini merged commit 0f7dc62 into antvis:v5 May 22, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hustcc hustcc hustcc left review comments

@pearmini pearmini pearmini approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

V5 版本如何实现十字辅助线
4 participants
@Runtus @coveralls @pearmini @hustcc