Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Scarf based telemetry #39510

Merged
merged 7 commits into from
May 16, 2024
Merged

Add Scarf based telemetry #39510

merged 7 commits into from
May 16, 2024

Conversation

kaxil
Copy link
Member

@kaxil kaxil commented May 9, 2024

To take the discussion about adding Telemetry forward, I am creating a draft PR that adds some basic telemetry to send to Scarf.

Voting thread: https://lists.apache.org/thread/h1x2glvnd42rbj2q2rgpfo3pjhmpt307

I have added docs on the data collection as well as a way to opt-out of it.

Telemetry added at:

Data collected:

  • Airflow version
  • Python version
  • Platform System info: Linux/Darwin
  • Machine type: arm64/aarch64
  • Airflow Metadata DB: Postgres/MySQL
  • DB: sqlite/postgres
  • DB version: 12.6.3
  • Number of DAGs
image image image image image

My proposal will be that this data will only be provided to PMC members on request to start with. For now, I am using the trial version.

We should also add it to the Airflow website similar to apache/superset#25639.


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@boring-cyborg boring-cyborg bot added area:CLI area:UI Related to UI/UX. For Frontend Developers. area:webserver Webserver related Issues kind:documentation labels May 9, 2024
airflow/utils/scarf.py Outdated Show resolved Hide resolved
airflow/config_templates/config.yml Outdated Show resolved Hide resolved
airflow/config_templates/config.yml Outdated Show resolved Hide resolved
airflow/config_templates/config.yml Outdated Show resolved Hide resolved
docs/apache-airflow/faq.rst Outdated Show resolved Hide resolved
docs/apache-airflow/faq.rst Outdated Show resolved Hide resolved
docs/apache-airflow/faq.rst Outdated Show resolved Hide resolved
docs/apache-airflow/installation/installing-from-pypi.rst Outdated Show resolved Hide resolved
docs/apache-airflow/installation/installing-from-pypi.rst Outdated Show resolved Hide resolved
docs/apache-airflow/installation/installing-from-pypi.rst Outdated Show resolved Hide resolved
airflow/config_templates/config.yml Outdated Show resolved Hide resolved
@kaxil kaxil force-pushed the scarf branch 5 times, most recently from 0479db7 to b16caed Compare May 9, 2024 20:28
airflow/utils/scarf.py Show resolved Hide resolved
tests/utils/test_scarf.py Outdated Show resolved Hide resolved
airflow/settings.py Outdated Show resolved Hide resolved
airflow/www/views.py Outdated Show resolved Hide resolved
airflow/config_templates/config.yml Outdated Show resolved Hide resolved
docs/apache-airflow/faq.rst Outdated Show resolved Hide resolved
airflow/config_templates/config.yml Outdated Show resolved Hide resolved
kaxil added a commit to astronomer/airflow that referenced this pull request May 9, 2024
Similar to apache/superset#25065 and apache#39510 but this one doesn't need to wait for the VOTE since this embed it to Readme. More detail in https://docs.scarf.sh/web-traffic/

All of this data will be available to interested PMC members, and reported periodically in things like Town Hall & newsletters.
@kaxil kaxil mentioned this pull request May 9, 2024
kaxil added a commit that referenced this pull request May 9, 2024
Similar to apache/superset#25065 and #39510 but this one doesn't need to wait for the VOTE since this embed it to Readme. More detail in https://docs.scarf.sh/web-traffic/

All of this data will be available to interested PMC members, and reported periodically in things like Town Hall & newsletters.
@kaxil kaxil force-pushed the scarf branch 4 times, most recently from 200f210 to 7d8eb2d Compare May 9, 2024 23:57
kaxil added a commit to apache/airflow-site that referenced this pull request May 10, 2024
Similar to apache/superset#25065 and apache/airflow#39510 but this one doesn't need to wait for the VOTE since this adds a simple transparent tracking pixel. More detail in https://docs.scarf.sh/web-traffic/

All of this data will be available in Scarf, creds for which are shared to 1password for PMC members, and can be reported periodically in things like Town Hall or newsletters.
airflow/cli/commands/scheduler_command.py Outdated Show resolved Hide resolved
airflow/cli/commands/scheduler_command.py Outdated Show resolved Hide resolved
kaxil added a commit to apache/airflow-site that referenced this pull request May 10, 2024
Similar to apache/superset#25065 and apache/airflow#39510 but this one doesn't need to wait for the VOTE since this adds a simple transparent tracking pixel. More detail in https://docs.scarf.sh/web-traffic/

All of this data will be available in Scarf, creds for which are shared to 1password for PMC members, and can be reported periodically in things like Town Hall or newsletters.
RodrigoGanancia pushed a commit to RodrigoGanancia/airflow that referenced this pull request May 10, 2024
Similar to apache/superset#25065 and apache#39510 but this one doesn't need to wait for the VOTE since this embed it to Readme. More detail in https://docs.scarf.sh/web-traffic/

All of this data will be available to interested PMC members, and reported periodically in things like Town Hall & newsletters.
pateash pushed a commit to pateash/airflow that referenced this pull request May 13, 2024
Similar to apache/superset#25065 and apache#39510 but this one doesn't need to wait for the VOTE since this embed it to Readme. More detail in https://docs.scarf.sh/web-traffic/

All of this data will be available to interested PMC members, and reported periodically in things like Town Hall & newsletters.
@kaxil kaxil added this to the Airflow 2.10.0 milestone May 14, 2024
@kaxil kaxil marked this pull request as ready for review May 16, 2024 15:55
airflow/settings.py Outdated Show resolved Hide resolved
airflow/utils/scarf.py Show resolved Hide resolved
airflow/www/views.py Show resolved Hide resolved
airflow/utils/scarf.py Outdated Show resolved Hide resolved
@kaxil kaxil merged commit cd0c6a7 into apache:main May 16, 2024
42 checks passed
@kaxil kaxil deleted the scarf branch May 16, 2024 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:CLI area:UI Related to UI/UX. For Frontend Developers. area:webserver Webserver related Issues kind:documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants