-
Notifications
You must be signed in to change notification settings - Fork 13.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Scarf based telemetry #39510
Merged
Merged
Add Scarf based telemetry #39510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:CLI
area:UI
Related to UI/UX. For Frontend Developers.
area:webserver
Webserver related Issues
kind:documentation
labels
May 9, 2024
kaxil
commented
May 9, 2024
kaxil
force-pushed
the
scarf
branch
5 times, most recently
from
May 9, 2024 20:28
0479db7
to
b16caed
Compare
jscheffl
reviewed
May 9, 2024
kaxil
added a commit
to astronomer/airflow
that referenced
this pull request
May 9, 2024
Similar to apache/superset#25065 and apache#39510 but this one doesn't need to wait for the VOTE since this embed it to Readme. More detail in https://docs.scarf.sh/web-traffic/ All of this data will be available to interested PMC members, and reported periodically in things like Town Hall & newsletters.
kaxil
added a commit
that referenced
this pull request
May 9, 2024
Similar to apache/superset#25065 and #39510 but this one doesn't need to wait for the VOTE since this embed it to Readme. More detail in https://docs.scarf.sh/web-traffic/ All of this data will be available to interested PMC members, and reported periodically in things like Town Hall & newsletters.
kaxil
force-pushed
the
scarf
branch
4 times, most recently
from
May 9, 2024 23:57
200f210
to
7d8eb2d
Compare
kaxil
added a commit
to apache/airflow-site
that referenced
this pull request
May 10, 2024
Similar to apache/superset#25065 and apache/airflow#39510 but this one doesn't need to wait for the VOTE since this adds a simple transparent tracking pixel. More detail in https://docs.scarf.sh/web-traffic/ All of this data will be available in Scarf, creds for which are shared to 1password for PMC members, and can be reported periodically in things like Town Hall or newsletters.
kaxil
commented
May 10, 2024
kaxil
added a commit
to apache/airflow-site
that referenced
this pull request
May 10, 2024
Similar to apache/superset#25065 and apache/airflow#39510 but this one doesn't need to wait for the VOTE since this adds a simple transparent tracking pixel. More detail in https://docs.scarf.sh/web-traffic/ All of this data will be available in Scarf, creds for which are shared to 1password for PMC members, and can be reported periodically in things like Town Hall or newsletters.
RodrigoGanancia
pushed a commit
to RodrigoGanancia/airflow
that referenced
this pull request
May 10, 2024
Similar to apache/superset#25065 and apache#39510 but this one doesn't need to wait for the VOTE since this embed it to Readme. More detail in https://docs.scarf.sh/web-traffic/ All of this data will be available to interested PMC members, and reported periodically in things like Town Hall & newsletters.
jscheffl
reviewed
May 10, 2024
jscheffl
reviewed
May 10, 2024
pateash
pushed a commit
to pateash/airflow
that referenced
this pull request
May 13, 2024
Similar to apache/superset#25065 and apache#39510 but this one doesn't need to wait for the VOTE since this embed it to Readme. More detail in https://docs.scarf.sh/web-traffic/ All of this data will be available to interested PMC members, and reported periodically in things like Town Hall & newsletters.
uranusjr
reviewed
May 14, 2024
kaxil
requested review from
ryanahamilton,
ashb,
bbovenzi,
pierrejeambrun and
potiuk
as code owners
May 16, 2024 15:55
pankajkoti
approved these changes
May 16, 2024
phanikumv
reviewed
May 16, 2024
Use Pixel for Webserver & Update URL for scheduler Improve docs Convert variable to function
dstandish
reviewed
May 16, 2024
dstandish
reviewed
May 16, 2024
dstandish
reviewed
May 16, 2024
jscheffl
approved these changes
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area:CLI
area:UI
Related to UI/UX. For Frontend Developers.
area:webserver
Webserver related Issues
kind:documentation
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To take the discussion about adding Telemetry forward, I am creating a draft PR that adds some basic telemetry to send to Scarf.
Voting thread: https://lists.apache.org/thread/h1x2glvnd42rbj2q2rgpfo3pjhmpt307
I have added docs on the data collection as well as a way to opt-out of it.
Telemetry added at:
Data collected:
My proposal will be that this data will only be provided to PMC members on request to start with. For now, I am using the trial version.
We should also add it to the Airflow website similar to apache/superset#25639.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in newsfragments.