[OPENLINEAGE] Introduce AirflowJobFacet and AirflowStateRunFacet #39520
+997
−40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kacpermuda
commented
May 9, 2024
kacpermuda
force-pushed
the
ol-new-dag-facet
branch
3 times, most recently
from
35778b2
to
ea6a570
Compare
kacpermuda
changed the title
kacpermuda
force-pushed
the
ol-new-dag-facet
branch
from
ea6a570
to
d02af81
Compare
kacpermuda
force-pushed
the
ol-new-dag-facet
branch
2 times, most recently
from
3d6af0d
to
7c0e499
Compare
mobuchowski
reviewed
May 21, 2024
kacpermuda
force-pushed
the
ol-new-dag-facet
branch
3 times, most recently
from
77020dd
to
ec4bc16
Compare
|
I had to add some words to spelling wordlist, due to the docs error in CI here. Let me know if there is a better solution to that problem, but part of these words have already been present, just with different capitalization. |
kacpermuda
commented
May 22, 2024
| if not dag_run.dag: | ||
| return {} | ||
| return { | ||
| "airflowDag": AirflowJobFacet( |
There was a problem hiding this comment.
Any ideas for a better key than airflowDag here ?
@mobuchowski @JDarDagran
kacpermuda
force-pushed
the
ol-new-dag-facet
branch
from
ec4bc16
to
c57294d
Compare
|
I also added json specs for the facets, in a new directory. I was not sure if i should add the |
kacpermuda
force-pushed
the
ol-new-dag-facet
branch
from
c57294d
to
8a86b29
Compare
kacpermuda
force-pushed
the
ol-new-dag-facet
branch
3 times, most recently
from
44a2de1
to
c415d62
Compare
Signed-off-by: Kacper Muda <mudakacper@gmail.com>
kacpermuda
force-pushed
the
ol-new-dag-facet
branch
from
c415d62
to
773637a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #39467
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.