Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

openlineage: migrate OpenLineage provider to V2 facets. #39530

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

openlineage: migrate OpenLineage provider to V2 facets. #39530

wants to merge 4 commits into from
+755 −680

Conversation

JDarDagran
Copy link
Contributor

@JDarDagran JDarDagran commented May 9, 2024 •
edited

In OpenLineage/OpenLineage#2520 released in openlineage-python==1.13.1 there were introduced V2 classes for facets and events.

@JDarDagran JDarDagran marked this pull request as draft May 9, 2024 19:13
@JDarDagran JDarDagran force-pushed the openlineage/migrate-to-v2-facets branch 5 times, most recently from 2e86fb5 to 9947104 Compare May 15, 2024 19:08
@JDarDagran JDarDagran force-pushed the openlineage/migrate-to-v2-facets branch from 9947104 to fc72488 Compare May 21, 2024 10:30
@JDarDagran JDarDagran marked this pull request as ready for review May 21, 2024 10:31
@JDarDagran JDarDagran force-pushed the openlineage/migrate-to-v2-facets branch 3 times, most recently from 0479252 to e43e266 Compare May 21, 2024 20:44
@JDarDagran
Copy link
Contributor Author

I ran breeze testing tests --upgrade-boto tests/providers/docker in main branch with latest CI image - getting same error results.
Celery integration test seems flaky, no?

@JDarDagran JDarDagran force-pushed the openlineage/migrate-to-v2-facets branch from e43e266 to 74bc580 Compare May 21, 2024 21:32
@potiuk
Copy link
Member

potiuk commented May 22, 2024

I ran breeze testing tests --upgrade-boto tests/providers/docker in main branch with latest CI image - getting same error results.

#39747 should fix the docker test in "Latest Botocore".

@JDarDagran
Migrate OpenLineage proivder to V2 facets.
008eacf 
Signed-off-by: Jakub Dardzinski <kuba0221@gmail.com>
@JDarDagran
Migrate amazon to v2 facets.
59b25ae 
Signed-off-by: Jakub Dardzinski <kuba0221@gmail.com>
@JDarDagran
Migrate OL-dependent providers to v2 facets.
798ba70 
Signed-off-by: Jakub Dardzinski <kuba0221@gmail.com>
@JDarDagran
Migrate Google provider to V2 facets.
feaa46c 
Signed-off-by: Jakub Dardzinski <kuba0221@gmail.com>
@JDarDagran JDarDagran force-pushed the openlineage/migrate-to-v2-facets branch from 74bc580 to feaa46c Compare May 22, 2024 13:39
@mobuchowski
Copy link
Contributor

@JDarDagran we probably need to bump cross-provider version dependencies. If someone has older OL provider version, and bumps some of the other provider versions, the openlineage methods will fail.

@potiuk
Copy link
Member

potiuk commented May 22, 2024

As discussed with @mobuchowski -> we need to add back-compatibility try/import to past versions of the openlineage provider. We could even potentially add back-compatibility test suite for older version of of openlineage client < 1.13 to test it (symiliar to what we have in Pydantic/Botocore cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mobuchowski mobuchowski Awaiting requested review from mobuchowski mobuchowski is a code owner

@bolkedebruin bolkedebruin Awaiting requested review from bolkedebruin bolkedebruin is a code owner

@eladkal eladkal Awaiting requested review from eladkal eladkal is a code owner

@o-nikolas o-nikolas Awaiting requested review from o-nikolas o-nikolas is a code owner

@potiuk potiuk Awaiting requested review from potiuk potiuk is a code owner

@mik-laj mik-laj Awaiting requested review from mik-laj mik-laj is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
area:providers provider:openlineage AIP-53
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@JDarDagran @potiuk @mobuchowski