Implement AND logic checkbox for filtering DAGs #39564
Open
+87
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Francisco Fonseca <franciscodiasfonseca@tecnico.ulisboa.pt>
TiDeane
requested review from
ryanahamilton,
ashb,
bbovenzi and
pierrejeambrun
as code owners
boring-cyborg
bot
added
area:UI
amoghrajesh
reviewed
May 17, 2024
There was a problem hiding this comment.
Logic looks good here, but I am not so sure of how the UX turns up now. It seems to get much more cluttered. @bbovenzi WDYT?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements a small checkbox named "Use AND logic" under the "filter DAGs by tag" box, allowing users to toggle between filtering DAGs using AND logic or OR logic. If there are no matching DAGs, it resets the tags and displays a message saying "No matching DAG tags found" (which is the default behaviour). Developed in collaboration with @lotrias17.
Screenshots:
We also implemented a test in test_views_home.py.
The checkbox's state is saved in
localStorage. When filtering the DAGs by tag in views.py, it now checks if the checkbox is marked, and if so it filters by AND instead of by OR.closes: #38147
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.