Determine needs_expansion at time of serialization #39604
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dstandish
requested review from
uranusjr,
ryanahamilton,
ashb,
bbovenzi,
pierrejeambrun,
ephraimbuddy,
kaxil and
bolkedebruin
as code owners
boring-cyborg
bot
added
area:API
uranusjr
reviewed
May 14, 2024
uranusjr
reviewed
May 14, 2024
dstandish
force-pushed
the
determine-needs_expansion-at-time-of-serialization
branch
from
a92724b
to
18dc032
Compare
This way we do not necessarily need to also pass the dag and do the evaluation on the server side. (cherry picked from commit f6dfbc0df8b2189217b9d33db5bb2bab3122d359)
dstandish
force-pushed
the
determine-needs_expansion-at-time-of-serialization
branch
from
d7cd050
to
084b682
Compare
pankajkoti
reviewed
May 16, 2024
dstandish
force-pushed
the
determine-needs_expansion-at-time-of-serialization
branch
from
b248390
to
084b682
Compare
uranusjr
reviewed
May 20, 2024
Co-authored-by: Tzu-ping Chung <uranusjr@gmail.com>
uranusjr
approved these changes
May 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This way we do not necessarily need to also pass the dag and do the evaluation on the server side.