Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove mysql/postgres from extras before determining the installation_command_flags #39610

Conversation

macchiang
Copy link
Contributor

  • Fix the build error with the build-args INSTALL_MYSQL_CLIENT=false or INSTALL_POSTGRES_CLIENT=false

^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@boring-cyborg boring-cyborg bot added area:dev-tools area:production-image Production image improvements and fixes labels May 14, 2024
Copy link

boring-cyborg bot commented May 14, 2024

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@potiuk
Copy link
Member

potiuk commented May 14, 2024

Nice! Thanks!

@potiuk potiuk added this to the Airflow 2.9.2 milestone May 14, 2024
@potiuk
Copy link
Member

potiuk commented May 14, 2024

SOme static check failure. The other issue with tests is being fixed (broken main)

@potiuk potiuk force-pushed the fix-mysql-postgres-removing-failure-from-extras branch from a108664 to e9aeae2 Compare May 14, 2024 13:03
Dockerfile Outdated Show resolved Hide resolved
Copy link
Collaborator

@dirrao dirrao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congratulations on your first PR.
Are these indentation changes intentional? Can you look into the failing checks?

@macchiang macchiang force-pushed the fix-mysql-postgres-removing-failure-from-extras branch from e9aeae2 to 14058df Compare May 15, 2024 08:17
@macchiang
Copy link
Contributor Author

@potiuk @dirrao All fixed.

@potiuk
Copy link
Member

potiuk commented May 15, 2024

Still some static-checks failing (I recommend installing and running pre-commit locally, it will fix things for you.

@macchiang macchiang force-pushed the fix-mysql-postgres-removing-failure-from-extras branch from 14058df to da477eb Compare May 15, 2024 10:20
@macchiang
Copy link
Contributor Author

@potiuk All good now. 🚀

@Taragolis Taragolis merged commit b0e3915 into apache:main May 15, 2024
68 checks passed
Copy link

boring-cyborg bot commented May 15, 2024

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:dev-tools area:production-image Production image improvements and fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants