[improve](fe) Add -XX:NewRatio=2 explicitly in JAVA_OPT #34965
+1
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Issue Number: close #xxx
According to https://bugs.openjdk.org/browse/JDK-8153578, the default NewRatio is ignored when UseConcMarkSweepGC is used as the GC algorithm, and the value of CMSYoungGenPerWorker is used to calculate the young gen size.
And they said: "The details of this CMS behavior should be documented and the CR closed as not-a-bug."
The workaround is:
To set -XX:NewRatio=2 explicitly if we are using -XX:+UseConcMarkSweepGC
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...