[optimize](desc) display the correct data type of aggStateType #34968
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
|
run buildall |
|
PR approved by at least one committer and no changes requested. |
github-actions
bot
added
the
approved
|
PR approved by anyone and no changes requested. |
TPC-H: Total hot run time: 41955 ms |
TPC-DS: Total hot run time: 180846 ms |
ClickBench: Total hot run time: 30.26 s |
|
run external |
morrySnow
approved these changes
May 21, 2024
|
could u replace screenshot by code block? screeshot is hard to put into git message and not firendly for search engine |
OK, I modified my comment. |
yiguolei
pushed a commit
that referenced
this pull request
May 22, 2024
If a table column is AGG_STATE type, we can't get the clear defined data type if we use `desc tbl` statement.
create table a_table(
k1 int null,
k2 agg_state<max_by(int not null,int)> generic,
k3 agg_state<group_concat(string)> generic
)
aggregate key (k1)
distributed BY hash(k1) buckets 3
properties("replication_num" = "1");
before optimize:
mysql> desc a_table;
+-------+------------------------------------------------+------+-------+---------+---------+
| Field | Type | Null | Key | Default | Extra |
+-------+------------------------------------------------+------+-------+---------+---------+
| k1 | INT | Yes | true | NULL | |
| k2 | org.apache.doris.catalog.AggStateType@239f771c | No | false | NULL | GENERIC |
| k3 | org.apache.doris.catalog.AggStateType@2e535f50 | No | false | NULL | GENERIC |
+-------+------------------------------------------------+------+-------+---------+---------+
3 rows in set (0.00 sec)
after optimize:
mysql> desc a_table;
+-------+------------------------------------+------+-------+---------+---------+
| Field | Type | Null | Key | Default | Extra |
+-------+------------------------------------+------+-------+---------+---------+
| k1 | INT | Yes | true | NULL | |
| k2 | AGG_STATE<max_by(INT, INT NULL)> | No | false | NULL | GENERIC |
| k3 | AGG_STATE<group_concat(TEXT NULL)> | No | false | NULL | GENERIC |
+-------+------------------------------------+------+-------+---------+---------+
Co-authored-by: duanxujian <duanxujian@jd.com>
M1saka2003
pushed a commit
to M1saka2003/doris
that referenced
this pull request
May 24, 2024
…e#34968) If a table column is AGG_STATE type, we can't get the clear defined data type if we use `desc tbl` statement. create table a_table( k1 int null, k2 agg_state<max_by(int not null,int)> generic, k3 agg_state<group_concat(string)> generic ) aggregate key (k1) distributed BY hash(k1) buckets 3 properties("replication_num" = "1"); before optimize: mysql> desc a_table; +-------+------------------------------------------------+------+-------+---------+---------+ | Field | Type | Null | Key | Default | Extra | +-------+------------------------------------------------+------+-------+---------+---------+ | k1 | INT | Yes | true | NULL | | | k2 | org.apache.doris.catalog.AggStateType@239f771c | No | false | NULL | GENERIC | | k3 | org.apache.doris.catalog.AggStateType@2e535f50 | No | false | NULL | GENERIC | +-------+------------------------------------------------+------+-------+---------+---------+ 3 rows in set (0.00 sec) after optimize: mysql> desc a_table; +-------+------------------------------------+------+-------+---------+---------+ | Field | Type | Null | Key | Default | Extra | +-------+------------------------------------+------+-------+---------+---------+ | k1 | INT | Yes | true | NULL | | | k2 | AGG_STATE<max_by(INT, INT NULL)> | No | false | NULL | GENERIC | | k3 | AGG_STATE<group_concat(TEXT NULL)> | No | false | NULL | GENERIC | +-------+------------------------------------+------+-------+---------+---------+ Co-authored-by: duanxujian <duanxujian@jd.com>
dataroaring
pushed a commit
that referenced
this pull request
May 26, 2024
If a table column is AGG_STATE type, we can't get the clear defined data type if we use `desc tbl` statement.
create table a_table(
k1 int null,
k2 agg_state<max_by(int not null,int)> generic,
k3 agg_state<group_concat(string)> generic
)
aggregate key (k1)
distributed BY hash(k1) buckets 3
properties("replication_num" = "1");
before optimize:
mysql> desc a_table;
+-------+------------------------------------------------+------+-------+---------+---------+
| Field | Type | Null | Key | Default | Extra |
+-------+------------------------------------------------+------+-------+---------+---------+
| k1 | INT | Yes | true | NULL | |
| k2 | org.apache.doris.catalog.AggStateType@239f771c | No | false | NULL | GENERIC |
| k3 | org.apache.doris.catalog.AggStateType@2e535f50 | No | false | NULL | GENERIC |
+-------+------------------------------------------------+------+-------+---------+---------+
3 rows in set (0.00 sec)
after optimize:
mysql> desc a_table;
+-------+------------------------------------+------+-------+---------+---------+
| Field | Type | Null | Key | Default | Extra |
+-------+------------------------------------+------+-------+---------+---------+
| k1 | INT | Yes | true | NULL | |
| k2 | AGG_STATE<max_by(INT, INT NULL)> | No | false | NULL | GENERIC |
| k3 | AGG_STATE<group_concat(TEXT NULL)> | No | false | NULL | GENERIC |
+-------+------------------------------------+------+-------+---------+---------+
Co-authored-by: duanxujian <duanxujian@jd.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a table column is AGG_STATE type, we can't get the clear defined data type if we use
desc tblstatement.before optimize:
after optimize: