-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix](jdbc_catalog) fix error datetime literal caused be core #34977
[fix](jdbc_catalog) fix error datetime literal caused be core #34977
Conversation
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
run buildall |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PR approved by at least one committer and no changes requested. |
PR approved by anyone and no changes requested. |
run buildall |
run buildall |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
this PR introduce a behavior change, below case will failed after this PR CREATE TABLE `roles` (
role_id INT,
occupation VARCHAR(32),
camp VARCHAR(32),
register_time DATE
)
UNIQUE KEY(role_id)
PARTITION BY RANGE (role_id)
(
PARTITION p1 VALUES LESS THAN ("10")
)
DISTRIBUTED BY HASH(role_id) BUCKETS 1
PROPERTIES (
"replication_allocation" = "tag.location.default: 1",
"binlog.enable" = "true"
);
INSERT INTO `roles` VALUES
(0, 'who am I', NULL, NULL),
(1, 'mage', 'alliance', '2018-12-03 16:11:28'),
(2, 'paladin', 'alliance', '2018-11-30 16:11:28'),
(3, 'rogue', 'horde', '2018-12-01 16:11:28'),
(4, 'priest', 'alliance', '2018-12-02 16:11:28'),
(5, 'shaman', 'horde', NULL),
(6, 'warrior', 'alliance', NULL),
(7, 'warlock', 'horde', '2018-12-04 16:11:28'),
(8, 'hunter', 'horde', NULL); the original plan is right. the bug should be fixed on BE |
…apache#34977)" This reverts commit cddf62b. It introduce a behavior change, below case will failed after this PR CREATE TABLE `roles` ( role_id INT, occupation VARCHAR(32), camp VARCHAR(32), register_time DATE ) UNIQUE KEY(role_id) PARTITION BY RANGE (role_id) ( PARTITION p1 VALUES LESS THAN ("10") ) DISTRIBUTED BY HASH(role_id) BUCKETS 1 PROPERTIES ( "replication_allocation" = "tag.location.default: 1", "binlog.enable" = "true" ); INSERT INTO `roles` VALUES (0, 'who am I', NULL, NULL), (1, 'mage', 'alliance', '2018-12-03 16:11:28'), (2, 'paladin', 'alliance', '2018-11-30 16:11:28'), (3, 'rogue', 'horde', '2018-12-01 16:11:28'), (4, 'priest', 'alliance', '2018-12-02 16:11:28'), (5, 'shaman', 'horde', NULL), (6, 'warrior', 'alliance', NULL), (7, 'warlock', 'horde', '2018-12-04 16:11:28'), (8, 'hunter', 'horde', NULL); the original plan is right. the bug should be fixed on BE
…#34977)" (#35341) This reverts commit cddf62b. This reverts PR #34977. It introduce a behavior change, below case will failed after this PR CREATE TABLE `roles` ( role_id INT, occupation VARCHAR(32), camp VARCHAR(32), register_time DATE ) UNIQUE KEY(role_id) PARTITION BY RANGE (role_id) ( PARTITION p1 VALUES LESS THAN ("10") ) DISTRIBUTED BY HASH(role_id) BUCKETS 1 PROPERTIES ( "replication_allocation" = "tag.location.default: 1", "binlog.enable" = "true" ); INSERT INTO `roles` VALUES (0, 'who am I', NULL, NULL), (1, 'mage', 'alliance', '2018-12-03 16:11:28'), (2, 'paladin', 'alliance', '2018-11-30 16:11:28'), (3, 'rogue', 'horde', '2018-12-01 16:11:28'), (4, 'priest', 'alliance', '2018-12-02 16:11:28'), (5, 'shaman', 'horde', NULL), (6, 'warrior', 'alliance', NULL), (7, 'warlock', 'horde', '2018-12-04 16:11:28'), (8, 'hunter', 'horde', NULL); the original plan is right. the bug should be fixed on BE
Proposed changes
Issue Number: close #34975
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...