Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix](executor)Fix query has no coord add may cause report failed. #34978

Merged
merged 2 commits into from
May 17, 2024
Merged

[Fix](executor)Fix query has no coord add may cause report failed. #34978

merged 2 commits into from
May 17, 2024

Conversation

wangbo
Copy link
Contributor

@wangbo wangbo commented May 16, 2024

Proposed changes

1 Add a column query_type for schema table backend_active_tasks.
2 For external query, they has no coord addr, should skip it when report audit log to Fe.
3 Add strictly check for coord addr and QueryType in debug mode.

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@wangbo
Copy link
Contributor Author

wangbo commented May 16, 2024

run buildall

@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@wangbo
Copy link
Contributor Author

wangbo commented May 16, 2024

run buildall

@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label May 16, 2024
@github-actions GitHub Actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions GitHub Actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 35.70% (9004/25219)
Line Coverage: 27.37% (74484/272162)
Region Coverage: 26.61% (38507/144720)
Branch Coverage: 23.42% (19639/83852)
Coverage Report: http://coverage.selectdb-in.cc/coverage/f244c0bf3dcb3a556a21600da7ee7d638d8372f1_f244c0bf3dcb3a556a21600da7ee7d638d8372f1/report/index.html

mrhhsg
mrhhsg approved these changes May 17, 2024
View reviewed changes
Copy link
Member

@mrhhsg mrhhsg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wangbo wangbo merged commit 5718ec6 into apache:master May 17, 2024
26 of 28 checks passed
M1saka2003 pushed a commit to M1saka2003/doris that referenced this pull request May 24, 2024
@wangbo @M1saka2003
[Fix](executor)Fix query has no coord add may cause report failed. (a…
97385bf 
…pache#34978)
dataroaring pushed a commit that referenced this pull request May 26, 2024
@wangbo @dataroaring
[Fix](executor)Fix query has no coord add may cause report failed. (#…
8ed4b96 
…34978)
@wangbo wangbo mentioned this pull request Jun 5, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrhhsg mrhhsg mrhhsg approved these changes

@yiguolei yiguolei yiguolei approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@wangbo @doris-robot @mrhhsg @yiguolei