[FLINK-35300][cdc][mysql] Improve MySqlStreamingChangeEventSource to skip null events in event deserializer #3299
+8
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…skip null events in event deserializer
|
@lvyanquan Could you help review this PR? |
lvyanquan
reviewed
May 27, 2024
| @@ -257,6 +260,9 @@ public Event nextEvent(ByteArrayInputStream inputStream) throws IOException { | |||
| try { | |||
| // Delegate to the superclass ... | |||
| Event event = super.nextEvent(inputStream); | |||
| if (event == null) { | |||
| return null; | |||
There was a problem hiding this comment.
There is no logic to go to this place because currently we don't need to read the binlog file on the local path using com.github.shyiko.mysql.binlog.BinaryLogFileReader.
There was a problem hiding this comment.
+1, I also did't see why we need to skip the null events
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve MySqlStreamingChangeEventSource to skip null events in event deserializer.