Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-35323][runtime] Fix transform failure when one rule matches multiple tables with incompatible schema #3313

Merged
merged 1 commit into from
Jun 3, 2024

Conversation

yuxiqian
Copy link
Contributor

@yuxiqian yuxiqian commented May 11, 2024

This closes FLINK-35323.

Currently, Transform module doesn’t support handling multiple tables with different schema within one projection / filtering rule. A minimum reproducible example is:

transform:
  - source-table: DB.TABLE\.*
    projection: \*

If there are DB.TABLE1 and DB.TABLE2 in upstream source but with different schema, transform operator will panic. This is not intended and turns out to be related to incorrectly handled processor caching strategy. Fixing the cache key should resolve this problem.

Copy link
Contributor

@aiwenmo aiwenmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yuxiqian
Copy link
Contributor Author

Could @PatrickRen please take a look? Thanks!

Copy link
Contributor

@leonardBang leonardBang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, wait the CI

@leonardBang leonardBang merged commit 88afc5f into apache:master Jun 3, 2024
14 checks passed
@melin
Copy link

melin commented Jun 3, 2024

Table A_1 has the same schema as table A_2, but A_3 has more fields than A_1. This scenario is not supported. Added conditional judgment:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants