HIVE-28266: Iceberg: select count(*) from data_files metadata tables … #5253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asf-ci-hive
added
tests pending
tests failed
tests unstable
and removed
tests pending
tests failed
labels
deniskuzZ
reviewed
May 17, 2024
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergStorageHandler.java
Outdated
Show resolved
Hide resolved
difin
force-pushed
the
select_count_data_files
branch
from
04935ae
to
6779f12
Compare
asf-ci-hive
added
tests pending
tests failed
and removed
tests unstable
tests pending
labels
difin
force-pushed
the
select_count_data_files
branch
from
6779f12
to
2233cdb
Compare
zhangbutao
approved these changes
May 20, 2024
There was a problem hiding this comment.
+1 LGTM. Pending tests.
I also think there are some other similar places which query iceberg metadata tables but using the data table's statistics wrongly. We can fix them incrementally. Like #5215 which i am doing.
difin
force-pushed
the
select_count_data_files
branch
from
2233cdb
to
dbed050
Compare
asf-ci-hive
added
tests pending
tests unstable
and removed
tests unstable
tests pending
labels
asf-ci-hive
added
tests unstable
tests pending
and removed
tests pending
tests unstable
labels
deniskuzZ
reviewed
May 21, 2024
| @@ -1512,7 +1512,8 @@ private String collectColumnAndReplaceDummyValues(ExprNodeDesc node, String foun | |||
| private void fallbackToNonVectorizedModeBasedOnProperties(Properties tableProps) { | |||
| Schema tableSchema = SchemaParser.fromJson(tableProps.getProperty(InputFormatConfig.TABLE_SCHEMA)); | |||
| if (FileFormat.AVRO.name().equalsIgnoreCase(tableProps.getProperty(TableProperties.DEFAULT_FILE_FORMAT)) || | |||
| (tableProps.containsKey("metaTable") && isValidMetadataTable(tableProps.getProperty("metaTable"))) || | |||
| (tableProps.containsKey(IcebergAcidUtil.META_TABLE_PROPERTY) && | |||
| isValidMetadataTable(tableProps.getProperty(IcebergAcidUtil.META_TABLE_PROPERTY))) || | |||
There was a problem hiding this comment.
can't we simplify to isValidMetadataTable(tableProps.getProperty(IcebergAcidUtil.META_TABLE_PROPERTY)) and check for null?
…gives wrong result
difin
force-pushed
the
select_count_data_files
branch
from
dbed050
to
457b015
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…gives wrong result
What changes were proposed in this pull request?
Modified Iceberg method "canComputeQueryUsingStats" to return false for queries over metadata tables to make Hive execute query over metadata table instead of getting the result from statistics.
Why are the changes needed?
Presently, when running a SELECT COUNT(*) query over an Iceberg table X.data_files where X is a data table, the result returns number of records in X rather than in X.data_files.
Does this PR introduce any user-facing change?
No
Is the change a dependency upgrade?
No
How was this patch tested?
New query test added