-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HUDI-7763] Fix that multiple jmx reporter can exist if metadata enables #11226
base: master
Are you sure you want to change the base?
Conversation
jmxReporterServer = createJmxReport(host, port); | ||
LOG.info("Started JMX server on port " + port + "."); | ||
break; | ||
} catch (Exception e) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we catch specific exception type here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we catch specific exception type here?
c7b4028
Callee function catches all exceptions, then rethrow to HoodieException.
Thus, check causes and log messages in detail.
Thanks for comment
- catch exception that caused by already in use port
LOG.info("Skip for initializing jmx port " + port + " because of already in use"); | ||
} else { | ||
LOG.info("Failed to initialize jmx port " + port + ". " + e.getMessage()); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LOG.info("Failed to initialize jmx port " + port + ". ", e);
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
emit log if all unknown error occur
Change Logs
Impact
metrics - JmxReporter
Risk level (write none, low medium or high below)
low
Documentation Update
none
Contributor's checklist