AWS: Fix S3FileIO tests failing on ListObjects for Express buckets #10292
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
When S3FileIO integration tests were being ran against an S3 Express bucket, they were failing due to a change in Express requiring all ListObjects requests end with a delimiter (
/
).Fix
Changed the calls to ListObjects to end in
/
. This works because the prefix was always proceeded by a/
in tests.I'm avoiding changing
s3FileIO.listPrefix
here in case the previous functionality is required for external integrations.Testing
The tests still pass when ran under S3 Standard, and when ran under S3 Express, the ListPrefix test now passes, and bucket cleanup now works as expected.