[core] Fix collecting wrong sorted runs when compacting on custom branch #2950
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
schnappi17
force-pushed
the
PAIMON-2861
branch
2 times, most recently
from
56dc139
to
2ecf300
Compare
sunxiaojian
reviewed
Mar 7, 2024
There was a problem hiding this comment.
@schnappi17 Does prepareCommit() also need to be processed?
There was a problem hiding this comment.
@sunxiaojian You mean the calculation of latestCommittedIdentifier?
There was a problem hiding this comment.
You mean the calculation of
latestCommittedIdentifier?
@schnappi17 yes
|
@schnappi17 If #3029 Merged, do we no longer need the current processing method ? |
|
Fixed in #3029, close this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Linked issue: subtask #2861
When writing to a custom branch, the compaction within writer will picking the wrong sorted runs on the 'main' branch to compact, which will cause the commit conflict, like willing to delete files which never been added.
Tests
API and Format
Documentation