Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[flink][flink-cdc] Add FLOAT type adaptation to HAVE_SCALE_LIST #3281

Closed
wants to merge 3 commits into from
Closed

[flink][flink-cdc] Add FLOAT type adaptation to HAVE_SCALE_LIST #3281

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d4fad6b
fix kafka-cdc with canal-json, when use float, the running exception …
Apr 28, 2024
8265990
fix kafka-cdc getPrecision error, like FLOAT(4),DOUBLE(8)...
May 4, 2024
72dd5fe
fix kafka-cdc getScale error,.when there is no COMMA return zero, lik…
May 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
19 changes: 13 additions & 6 deletions ...imon-flink-cdc/src/main/java/org/apache/paimon/flink/action/cdc/mysql/MySqlTypeUtils.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,7 @@ public class MySqlTypeUtils {
private static final String COMMA = ",";

private static final List<String> HAVE_SCALE_LIST =
Arrays.asList(DECIMAL, NUMERIC, DOUBLE, REAL, FIXED);
Arrays.asList(DECIMAL, NUMERIC, DOUBLE, REAL, FIXED, FLOAT);
private static final List<String> MAP_TO_DECIMAL_TYPES =
Arrays.asList(
NUMERIC,
Expand Down Expand Up @@ -382,7 +382,11 @@ public static int getPrecision(String typeName) {
&& typeName.contains(RIGHT_BRACKETS)
&& isScaleType(typeName)) {
return Integer.parseInt(
typeName.substring(typeName.indexOf(LEFT_BRACKETS) + 1, typeName.indexOf(COMMA))
typeName.substring(
typeName.indexOf(LEFT_BRACKETS) + 1,
typeName.contains(COMMA)
? typeName.indexOf(COMMA)
: typeName.indexOf(RIGHT_BRACKETS))
.trim());
} else if ((typeName.contains(LEFT_BRACKETS)
&& typeName.contains(RIGHT_BRACKETS)
Expand All @@ -405,10 +409,13 @@ public static int getScale(String typeName) {
if (typeName.contains(LEFT_BRACKETS)
&& typeName.contains(RIGHT_BRACKETS)
&& isScaleType(typeName)) {
return Integer.parseInt(
typeName.substring(
typeName.indexOf(COMMA) + 1, typeName.indexOf(RIGHT_BRACKETS))
.trim());
return typeName.contains(COMMA)
? Integer.parseInt(
typeName.substring(
typeName.indexOf(COMMA) + 1,
typeName.indexOf(RIGHT_BRACKETS))
.trim())
: 0;
} else {
// When missing scale of the decimal, we
// use the max scale to avoid parse error
Expand Down