-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feat][broker] PIP-264: Add schema registry metrics #22624
Open
dragosvictor
wants to merge
15
commits into
apache:master
Choose a base branch
from
dragosvictor:dmisca-pip-264-schema-registry-metrics
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[feat][broker] PIP-264: Add schema registry metrics #22624
dragosvictor
wants to merge
15
commits into
apache:master
from
dragosvictor:dmisca-pip-264-schema-registry-metrics
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
doc-required
Your PR changes impact docs and you will update later.
label
May 1, 2024
lhotari
approved these changes
May 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…ma-registry-metrics
dao-jun
approved these changes
May 2, 2024
…ma-registry-metrics
/pulsarbot rerun-failure-checks |
…ma-registry-metrics
…ma-registry-metrics
…ma-registry-metrics
…ma-registry-metrics
…ma-registry-metrics
@dragosvictor please resolve the merge conflicts in this PR |
…ma-registry-metrics
…ma-registry-metrics
dragosvictor
force-pushed
the
dmisca-pip-264-schema-registry-metrics
branch
from
May 30, 2024 17:14
d95c7f7
to
d5c746b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PIP-264
Motivation
Exposes the current Schema Registry metrics described in the doc using OpenTelemetry.
Modifications
Modified
SchemaRegistryStats
to expose metricspulsar.broker.request.schema_registry.duration
andpulsar.broker.operation.schema_registry.compatibility_check.count
. A full description of these metrics can be found in the documentation PR: apache/pulsar-site#892. Unlike the former approach, this records request latencies irrespective of the response type (success/failure), thus simplifying the design.Modified
SchemaRegistryStats
to not be a singleton. This fits better with the OpenTelemetry design and allows for easier testing, as resources are not shared across tests. It broke parameterized test classSimpleSchemaTest
, which had to be fixed by reordering the test based on the test instance object first. This way, no two instances of the same metric co-exist, as expected by the OpenTelemetry SDK.Verifying this change
This change added tests and can be verified as follows:
SchemaServiceTest#testSchemaRegistryMetrics
andSchemaServiceTest#checkIsCompatible
to validate the new metricsDoes this pull request potentially affect one of the following parts:
Documentation
doc
doc-required
[feat][broker] PIP-264: Add schema registry metrics pulsar-site#892doc-not-needed
doc-complete
Matching PR in forked repository
PR in forked repository: dragosvictor#19