[Altered][JobConfigParser] removed redundant lines of code #6639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hisoka-X
reviewed
Apr 9, 2024
Comment on lines
224
to
230
| static String createSinkActionName(int configIndex, String pluginName, String table) { | ||
| return String.format("Sink[%s]-%s-%s", configIndex, pluginName, table); | ||
| if (table != null && !table.isEmpty()) { | ||
| return String.format("Sink[%s]-%s", configIndex, pluginName, table); | ||
| } else { | ||
| return String.format("Source[%s]-%s", configIndex, pluginName); | ||
| } | ||
| } |
There was a problem hiding this comment.
Hi @anirudh-hegde , thanks for created this PR, but I think this change has no obvious meaning and is more confusing for callers.
There was a problem hiding this comment.
Hi @anirudh-hegde , thanks for created this PR, but I think this change has no obvious meaning and is more confusing for callers.
I think using if condition instead of writing two functions is a better practice.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this pull request
Removed redundant code to optimize the code
Does this PR introduce any user-facing change?
No
Check list
New License Guide
release-note.