New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Hotfix][Postgres-CDC] Fix read data missing when restore #6785
Conversation
44f3804
to
fca70f3
Compare
// create the slot if it doesn't exist, otherwise update slot to add new | ||
// table(job restore and add table) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line 240 in 4d9287f
"ALTER PUBLICATION %s ADD TABLE %s;", |
How about add a test case for this scene? |
1. The job was not added new tables into `publication` before start to snapshot read. 2. Delete of database logs did not use checkpoint offset.
fca70f3
to
cd2acad
Compare
@@ -113,7 +116,7 @@ public void pollNext(Collector<T> output) throws Exception { | |||
|
|||
@Override | |||
public void notifyCheckpointComplete(long checkpointId) throws Exception { | |||
dataSourceDialect.notifyCheckpointComplete(checkpointId); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Purpose of this pull request
publication
before start to snapshot read.Does this PR introduce any user-facing change?
No
How was this patch tested?
Check list
New License Guide
release-note
.