Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SPARK-48256][BUILD] Add a rule to check file headers for the java side, and fix inconsistent files #46557

Closed
wants to merge 1 commit into from
Closed

[SPARK-48256][BUILD] Add a rule to check file headers for the java side, and fix inconsistent files #46557

wants to merge 1 commit into from

Conversation

panbingkun
Copy link
Contributor

@panbingkun panbingkun commented May 13, 2024 •
edited

What changes were proposed in this pull request?

The pr aims to add a rule to check file headers for the java side, and fix inconsistent files.

Why are the changes needed?

On the scala side, we have a rule to check file header, but we have no corresponding rules on the java side to do the same thing.

Does this PR introduce any user-facing change?

Yes, only for spark developers.

How was this patch tested?

  • Manually test
sh dev/lint-java
Using `mvn` from path: /Users/panbingkun/Developer/infra/maven/maven/bin/mvn
-e Checkstyle checks passed.
  • Pass GA.

Was this patch authored or co-authored using generative AI tooling?

No.

@panbingkun panbingkun marked this pull request as ready for review May 13, 2024 23:33
@panbingkun
Copy link
Contributor Author

cc @HyukjinKwon

dongjoon-hyun
dongjoon-hyun approved these changes May 15, 2024
View reviewed changes
Copy link
Member

@dongjoon-hyun dongjoon-hyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HyukjinKwon HyukjinKwon HyukjinKwon approved these changes

@dongjoon-hyun dongjoon-hyun dongjoon-hyun approved these changes

Assignees
No one assigned
Labels
BUILD CORE SQL
Projects
None yet
Milestone
No milestone
3 participants
@panbingkun @HyukjinKwon @dongjoon-hyun