[SPARK-48296][SQL] Codegen Support for to_xml
#46591
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
panbingkun
commented
May 15, 2024
| @@ -55,7 +55,7 @@ class XmlFunctionsSuite extends QueryTest with SharedSparkSession { | |||
| val options = Map("rowTag" -> "foo").asJava | |||
|
|
|||
| checkAnswer( | |||
| df.select(from_xml($"value", schema)), | |||
| df.select(from_xml($"value", schema, options)), | |||
There was a problem hiding this comment.
Obviously, its usage does not match the title of UT
panbingkun
changed the title
to_xml
panbingkun
commented
May 16, 2024
| @@ -186,9 +186,6 @@ case class SchemaOfXml( | |||
| @transient | |||
| private lazy val xmlOptions = new XmlOptions(options, "UTC") | |||
|
|
|||
| @transient | |||
| private lazy val xmlFactory = xmlOptions.buildXmlFactory() | |||
There was a problem hiding this comment.
This variable xmlFactory is not used in the expression SchemaOfXml, so it is deleted here. It has no strong relationship with this PR.
yaooqinn
reviewed
May 16, 2024
|
|
||
| override def inputTypes: Seq[AbstractDataType] = StructType :: Nil | ||
|
|
||
| override def prettyName: String = "to_xml" | ||
|
|
||
| override protected def withNewChildInternal(newChild: Expression): StructsToXml = | ||
| copy(child = newChild) | ||
|
|
||
| override protected def doGenCode(ctx: CodegenContext, ev: ExprCode): ExprCode = { |
There was a problem hiding this comment.
Simply
override protected def doGenCode(ctx: CodegenContext, ev: ExprCode): ExprCode = {
val expr = ctx.addReferenceObj("this", this)
defineCodeGen(ctx, ev, input => s"(UTF8String) $expr.nullSafeEval($input)")
}There was a problem hiding this comment.
yeah, updated.
thanks!
There was a problem hiding this comment.
We can also revert other refactoring?
There was a problem hiding this comment.
let me have a try.
yaooqinn
reviewed
May 16, 2024
sql/core/src/test/scala/org/apache/spark/sql/XmlFunctionsSuite.scala
Outdated
Show resolved
Hide resolved
yaooqinn
approved these changes
May 16, 2024
….scala Co-authored-by: Kent Yao <yao@apache.org>
|
Thanks @panbingkun, merged to master |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
The PR adds
Codegen Supportforto_xml.Why are the changes needed?
Improve codegen coverage.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Was this patch authored or co-authored using generative AI tooling?
No.