-
Notifications
You must be signed in to change notification settings - Fork 321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow switching the Swift version in expressions #8775
Allow switching the Swift version in expressions #8775
Conversation
@swift-ci test |
58d30e9
to
112c7c4
Compare
@swift-ci test |
llvm::VersionTuple(version / 100, version % 100); | ||
} | ||
if (lang_opts.EffectiveLanguageVersion >= swift::version::Version({6})) | ||
lang_opts.StrictConcurrencyLevel = swift::StrictConcurrency::Complete; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does the compiler not do this when the version is set to >=6
? If lldb is doing this, but the compiler isn't, is that going to cause some issues in some cases?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also, I'm confused by the title. The diff appears to affect StrictConcurrencyLevel
, and the language version already appears supported.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Both excellent questions. I asked, and the compiler sets this flag in an ad-hoc fashion that isn't readily available to reuse. This also seems to be the only flag that behaves this way.
The title is wrong. This just adds a test.
@swift-ci test linux |
test with apple/swift#73757 |
No description provided.