[Macros] Fix column calculation in MacroExpansionContext for plugins #2656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please test |
ahoppen
reviewed
May 17, 2024
|
|
||
| // MARK: - SourceLocationMacros | ||
|
|
||
| runSourceLoctionMacrosPlayground() |
There was a problem hiding this comment.
Would it make sense to also have an XCTest test for this that will fail if this breaks instead of just a print in the macro examples?
There was a problem hiding this comment.
Unfortunately XCTest case's expansion (assertMacroExpansion) doesn't use this code path.
When retriving a location for a node at the first line, column calculation was incorrect. 'column' of 'PluginMessage.Syntax' is 1-based, so we need to '-1' when using it as a offset.
rintaro
force-pushed
the
macros-expansioncontext-column
branch
from
35cfbc6
to
9867998
Compare
|
@swift-ci Please test |
|
@swift-ci Please test Windows |
ahoppen
approved these changes
May 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When retriving a location for a node at the first line, column calculation was incorrect. 'column' of 'PluginMessage.Syntax' is 1-based, so we need to '-1' when using it as a offset.