test: Enable server tests for the PRs with base PG branch #33429
Conversation
WalkthroughWalkthroughThis update introduces a significant change by replacing the environment variable Changes
Possibly related issues
Recent Review DetailsConfiguration used: CodeRabbit UI Files selected for processing (1)
Additional Context UsedShellCheck (8)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
Out of diff range and nitpick comments (2)
.github/workflows/quality-checks.yml (1)
5-5: Add a comment to explain the new branch trigger.Consider adding a comment to explain why the
pgbranch is included in the trigger list for better context and maintainability..github/workflows/server-build.yml (1)
20-24: Ensure theis-pgparameter is documented.Make sure to update the documentation to include the new
is-pgparameter and its purpose.
There was a problem hiding this comment.
Actionable comments posted: 1
Out of diff range and nitpick comments (1)
app/server/build.sh (1)
Line range hint
48-48: Check exit code directly withif mvn clean package "$@";.Instead of checking the exit code indirectly with
$?, check it directly withif mvn clean package "$@";.- if [[ $? -eq 0 ]]; then + if mvn clean package "$@"; then
Failed server tests
|
There was a problem hiding this comment.
Actionable comments posted: 2
Out of diff range and nitpick comments (1)
app/server/build.sh (1)
Line range hint
48-48: Check exit code directly.- if [[ $? -eq 0 ]]; then + if mvn clean package "$@"; thenCheck the exit code directly with the command instead of using
$?.
...r/src/main/java/com/appsmith/server/migrations/db/ce/Migration056UpdateDbUriEnvVariable.java
Outdated
Show resolved
Hide resolved
app/server/appsmith-server/src/main/resources/application-production.properties
Outdated
Show resolved
Hide resolved
Failed server tests
|
app/server/appsmith-server/src/main/resources/application.properties
Outdated
Show resolved
Hide resolved
...r/src/main/java/com/appsmith/server/migrations/db/ce/Migration056UpdateDbUriEnvVariable.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Shrikant Sharat Kandula <shrikant@appsmith.com>
…nable-server-tests-for-pg
…org/appsmith into feat/enable-server-tests-for-pg
abhvsn
added
ok-to-test
|
/build-deploy-preview skip-tests=true recreate=true |
|
Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/9163161858. |
There was a problem hiding this comment.
Actionable comments posted: 0
Out of diff range and nitpick comments (7)
deploy/helm/README.md (7)
Line range hint
2-2: Correct the repeated word "Appsmith".- # Appsmith Appsmith is a JS-based internal tool development platform. + # Appsmith is a JS-based internal tool development platform.
Line range hint
7-7: Correct the spelling of "Elastic Search" to "Elasticsearch".- Elastic Search, DynamoDB, Redis, & MSFT SQL Server. + Elasticsearch, DynamoDB, Redis, & MSFT SQL Server.
Line range hint
20-20: Correct the verb form "bootstrap" to "bootstraps".- This chart bootstrap an [Appsmith](https://github.com/appsmithorg/appsmith) deployment on a [Kubernetes](kubernetes.io) cluster using [Helm](https://helm.sh) package manager. + This chart bootstraps an [Appsmith](https://github.com/appsmithorg/appsmith) deployment on a [Kubernetes](kubernetes.io) cluster using [Helm](https://helm.sh) package manager.
Line range hint
37-37: Correct the phrase "should be enable" to "should be enabled".- Kubernetes NGINX Ingress Controller should be enable on your cluster by default. + Kubernetes NGINX Ingress Controller should be enabled on your cluster by default.
Line range hint
113-113: Remove the duplicated phrase "to expose".- | Appsmith service node port to expose to expose | `8000` | + | Appsmith service node port to expose | `8000` |
Line range hint
148-151: Add hyphens to "auto update" to form "auto-update".- ### Auto update chart's image + ### Auto-update chart's image - | `autoupdate.enabled` | Enable auto update Helm chart's image | `true` | + | `autoupdate.enabled` | Enable auto-update Helm chart's image | `true` |
Line range hint
207-208: Correct the verb form "setup" to "set up" and "install" to "installed".- If you wish to publish your Appsmith to the world through the Internet, you will need to setup the Ingress controller firstly. + If you wish to publish your Appsmith to the world through the Internet, you will need to set up the Ingress controller firstly. - In case of you have not install the Helm chart yet, you can run the below command to install it with exposing Appsmith + In case you have not installed the Helm chart yet, you can run the below command to install it while exposing Appsmith
|
Deploy-Preview-URL: https://ce-33429.dp.appsmith.com |
Failed server tests
|
…nable-server-tests-for-pg
…org/appsmith into feat/enable-server-tests-for-pg
abhvsn
added
ok-to-test
app/server/appsmith-server/src/main/java/com/appsmith/server/configurations/CommonDBConfig.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Shrikant Sharat Kandula <shrikant@appsmith.com>
…org/appsmith into feat/enable-server-tests-for-pg
abhvsn
added
ok-to-test
abhvsn
changed the title
github-actions
bot
added
skip-changelog
Description
pgas the base branch.APPSMITH_MONGODB_URItoAPPSMITH_DB_URLAutomation
/ok-to-test tags="@tag.Sanity, @tag.GenerateCRUD, @tag.Fork"
🔍 Cypress test results
Tip
🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/9174148396
Commit: 762b425
Cypress dashboard url: Click here!
Communication
Should the DevRel and Marketing teams inform users about this change?