-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Adds airgapped handling of empty canvas hints #33430
Conversation
WalkthroughWalkthroughThe update involves enhancing the Page Load tests to selectively validate the presence of a specific hint ( Changes
Recent Review DetailsConfiguration used: CodeRabbit UI Files selected for processing (1)
Files skipped from review as they are similar to previous changes (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
app/client/cypress/e2e/Regression/ClientSide/ExplorerTests/Page_Load_Spec.js
Show resolved
Hide resolved
app/client/cypress/e2e/Regression/ClientSide/ExplorerTests/Page_Load_Spec.js
Show resolved
Hide resolved
@rahulbarwal why are you not running "IDE" tag? and why did we add "Templates" tag to it? i don't see anything related to template in this spec |
Description
Fixes airgapped condition for empty canvas state.
Fixes #
Issue Number
or
Fixes
Issue URL
Warning
If no issue exists, please create an issue first, and check with the maintainers if the issue is valid.
Automation
/ok-to-test tags="@tag.IDE"
馃攳 Cypress test results
Tip
馃煝 馃煝 馃煝 All cypress tests have passed! 馃帀 馃帀 馃帀
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/9077312350
Commit: 71a84f2
Cypress dashboard url: Click here!
Communication
Should the DevRel and Marketing teams inform users about this change?