Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add ability to hide certain annotations on secret resources #18216

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

svghadi
Copy link
Contributor

@svghadi svghadi commented May 14, 2024

Closes #15693
Implements hide-annotations.md proposal.
Depends on argoproj/gitops-engine#577

This PR adds ability to define a list of annotations to hide on secret resources. A new hide.secret.annotations key is introduced in argocd-cm configmap which can be used to configure a list of annotation keys to hide on secret resources.

hidden-annotations.mov

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

Signed-off-by: Siddhesh Ghadi <sghadi1203@gmail.com>
@svghadi svghadi changed the title feat: Add option to hide certain annotations on secret resources in the Argo CD Web UI feat: Add option to hide certain annotations on secret resources May 14, 2024
Signed-off-by: Siddhesh Ghadi <sghadi1203@gmail.com>
@svghadi svghadi changed the title feat: Add option to hide certain annotations on secret resources feat: Add ability to hide certain annotations on secret resources May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide ability to hide defined annotations in ArgoCD web UI
1 participant