Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(metric): add ls-remote request fail metric(#17956) #18250

Merged
merged 1 commit into from
May 22, 2024
Merged

feat(metric): add ls-remote request fail metric(#17956) #18250

merged 1 commit into from
May 22, 2024

Conversation

Jack-R-lantern
Copy link
Contributor

@Jack-R-lantern Jack-R-lantern commented May 16, 2024 •
edited

Added argocd_git_lsremote_fail_total metric.
Increment this metric if a git ls-remote request fails.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

Closes #17956

@Jack-R-lantern Jack-R-lantern requested a review from a team as a code owner May 16, 2024 15:07
@Jack-R-lantern Jack-R-lantern marked this pull request as draft May 16, 2024 15:07
@Jack-R-lantern Jack-R-lantern changed the title feat(metric): add ls-remote request fail metric feat(metric): add ls-remote request fail metric(#17956) May 16, 2024
@Jack-R-lantern Jack-R-lantern force-pushed the ISSUE-17956/git_ls-remote_failure_counter branch 2 times, most recently from d6f495b to 21266e3 Compare May 17, 2024 11:37
@Jack-R-lantern
feat: add ls-remote request fail metric
4631447 
Added argocd_git_lsremote_fail_total metric.
Increment this metric if a git ls-remote request fails.

Signed-off-by: Jack-R-lantern <tjdfkr2421@gmail.com>
@Jack-R-lantern Jack-R-lantern force-pushed the ISSUE-17956/git_ls-remote_failure_counter branch from 21266e3 to 4631447 Compare May 17, 2024 12:02
@Jack-R-lantern Jack-R-lantern marked this pull request as ready for review May 17, 2024 12:48
csantanapr
csantanapr reviewed May 19, 2024
View reviewed changes
Copy link
Member

@csantanapr csantanapr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a useful error metric to expose

@Jack-R-lantern
Copy link
Contributor Author

@csantanapr
Is there anything else I need to implement?

todaywasawesome
todaywasawesome approved these changes May 22, 2024
View reviewed changes
Copy link
Contributor

@todaywasawesome todaywasawesome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pasha-codefresh pasha-codefresh merged commit ee9b38f into argoproj:master May 22, 2024
29 checks passed
@pasha-codefresh
Copy link
Member

Thank you for your contribution

@ebuildy
Copy link
Contributor

ebuildy commented May 22, 2024

Wonderful many thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@csantanapr csantanapr csantanapr left review comments

@todaywasawesome todaywasawesome todaywasawesome approved these changes

@pasha-codefresh pasha-codefresh pasha-codefresh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[metrics] git ls-remote failure counter
5 participants
@Jack-R-lantern @pasha-codefresh @ebuildy @csantanapr @todaywasawesome