Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added the comment to support CLI message to get extended output #18253

Merged
merged 5 commits into from
May 23, 2024

Conversation

nikzayn
Copy link
Contributor

@nikzayn nikzayn commented May 16, 2024

#18226
Added the comment to support CLI message to get extended output

Checklist:

@nikzayn nikzayn requested a review from a team as a code owner May 16, 2024 15:41
@pasha-codefresh
Copy link
Member

@nikzayn you need to run make codegen locally and push generated manifests

@nikzayn
Copy link
Contributor Author

nikzayn commented May 17, 2024

@nikzayn you need to run make codegen locally and push generated manifests

Thanks, for updating. I will do that.

nikzayn and others added 2 commits May 17, 2024 13:48
Copy link
Member

@ishitasequeira ishitasequeira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nikzayn , it seems the manifests are not generated properly. Can you execute make manifests or make manifests-local and push the changes?

@nikzayn
Copy link
Contributor Author

nikzayn commented May 18, 2024

make manifests

Hey @ishitasequeira, I tried running both commands but no changes are happening at the repo which I can commit.

Copy link
Member

@ishitasequeira ishitasequeira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you execute make codegen-local? That should fix the generated code.

@nikzayn
Copy link
Contributor Author

nikzayn commented May 22, 2024

make codegen-local

I tried running this, and it gave me this error:

unknown flag: --output-base
make: *** [protogen-fast] Error 2

Copy link
Member

@ishitasequeira ishitasequeira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you make sure you have the correct protogen version installed locally?

You could use install-tools-local to have all the correct version of tools installed

Signed-off-by: nikzayn <nikhilvaidyar1997@gmail.com>
@nikzayn
Copy link
Contributor Author

nikzayn commented May 22, 2024

Can you make sure you have the correct protogen version installed locally?

You could use install-tools-local to have all the correct version of tools installed

Thanks for this, I have run this command and added the changes.

Copy link

codecov bot commented May 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.68%. Comparing base (d73eb8f) to head (4e4314a).

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #18253   +/-   ##
=======================================
  Coverage   45.68%   45.68%           
=======================================
  Files         353      353           
  Lines       46965    46965           
=======================================
  Hits        21454    21454           
  Misses      22772    22772           
  Partials     2739     2739           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@ishitasequeira ishitasequeira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @nikzayn !! LGTM!!

@ishitasequeira ishitasequeira enabled auto-merge (squash) May 23, 2024 00:46
@ishitasequeira ishitasequeira merged commit 600737a into argoproj:master May 23, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants