[lua] suggestion: move canvas behind foreground dialog #4465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| class DialogWindow : public ui::Window, | ||
| public EditorObserver { | ||
| public: | ||
| bool moveTool; |
There was a problem hiding this comment.
warning: member variable 'moveTool' has public visibility [misc-non-private-member-variables-in-classes]
bool moveTool;
^| ToolBar::instance()->selectTool(m_oldTool); | ||
| } | ||
|
|
||
| void onOpen(Event& ev) override { |
There was a problem hiding this comment.
warning: parameter 'ev' is unused [misc-unused-parameters]
Suggested change
| void onOpen(Event& ev) override { | |
| void onOpen(Event& /*ev*/) override { |
| } | ||
| } | ||
|
|
||
| void onBeforeClose(CloseEvent& ev) override { |
There was a problem hiding this comment.
warning: parameter 'ev' is unused [misc-unused-parameters]
Suggested change
| void onBeforeClose(CloseEvent& ev) override { | |
| void onBeforeClose(CloseEvent& /*ev*/) override { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It would be useful to allow moving and zooming on canvas when showing dialog in foreground, similar to built-in filter dialogs, e.g. like so:
Without it things work same as before. It's really nice to have for previewing color adjustment or other intermediary changes to the image.
There's one problem though: it's still possible to use ctrl key to move layers which feels like a problem. Filters avoid this because the sprite is locked ("Sprite is used by backup/data recovery task") but I'm not sure it's okay to do so here because the script also needs to use it? I wonder if there is a simple solution to this.
I agree that my contributions are licensed under the Individual Contributor License Agreement V4.0 ("CLA") as stated in https://github.com/igarastudio/cla/blob/main/cla.md
I have signed the CLA following the steps given in https://github.com/igarastudio/cla#signing