Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop using flynt #16421

Merged
merged 1 commit into from
May 20, 2024
Merged

Stop using flynt #16421

merged 1 commit into from
May 20, 2024

Conversation

eerovaher
Copy link
Member

Description

flynt is a tool that can replace %-formatted strings and str.format() calls with f-strings, but in practice it doesn't seem to be doing anything ruff couldn't do.

Closes #14934

  • By checking this box, the PR author has requested that maintainers do NOT use the "Squash and Merge" button. Maintainers should respect this when possible; however, the final decision is at the discretion of the maintainer that merges the PR.

`flynt` is a tool that can replace %-formatted strings and
`str.format()` calls with f-strings, but in practice it doesn't seem to
be doing anything `ruff` couldn't do.
Copy link

github-actions bot commented May 9, 2024

Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see instructions for rebase and squash.
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the "Extra CI" label. Codestyle issues can be fixed by the bot.
  • Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label. If this is a manual backport, use the "skip-changelog-checks" label unless special changelog handling is necessary.
  • Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate "backport-X.Y.x" label(s) before merge.

Copy link
Member

@pllim pllim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@WilliamJamieson added this in #14278 so I want to see if he has objection. But if you do not hear back in a week or two, feel free to merge. Thanks!

@neutrinoceros
Copy link
Contributor

We're a week or two later 👀

@pllim pllim merged commit 68a0abb into astropy:main May 20, 2024
29 of 30 checks passed
@eerovaher eerovaher deleted the rm-flynt branch May 20, 2024 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace flynt with ruff?
4 participants