-
Notifications
You must be signed in to change notification settings - Fork 371
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix emscripten build #258
base: master
Are you sure you want to change the base?
Fix emscripten build #258
Conversation
CC may be resolved as absolute path, such as /emsdn_portable/sdk/emcc. And add empty __init__.py files.
the default encoding is utf8, and will print like `u'xxx'`
Some tests needs dynamic library. Since default build will test and generate docs, so emscripten build just need the wasm module
use 'aubio' as exported module name
hi @liulongbiao, thanks! looks good to me, except the first commit. will comment in details. cheers, piem |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- why would you need to create the
__init__.py
files? these directories are not python modules - what's missing with the current test?
>>> 'emcc' in '/path/to/emcc -E'
True
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tests and examples were correctly build last time i checked, and could be run with node
. why disable them? see wscript#L528
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you describe a configuration where the list c_mangled_names
is not generated correctly?
without the
|
When I execute the script
|
hi @liulongbiao please don't close this issue until it is resolved. i will have a deeper look. thanks for your patience, Paul |
Codecov Report
@@ Coverage Diff @@
## master #258 +/- ##
=======================================
Coverage 88.09% 88.09%
=======================================
Files 124 124
Lines 9716 9716
Branches 1729 1729
=======================================
Hits 8559 8559
Misses 1110 1110
Partials 47 47 Continue to review full report at Codecov.
|
Fixed some issue when I use docker to build aubio with emscripten.
Now we can use Docker to build WebAssembly module with :