Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

repo-tools: add additional properties to generate command #24810

Merged
merged 4 commits into from
May 27, 2024
Merged

repo-tools: add additional properties to generate command #24810

merged 4 commits into from
May 27, 2024

Conversation

nurbaysymbat
Copy link
Contributor

@nurbaysymbat nurbaysymbat commented May 16, 2024 •
edited

Hey, I just made a Pull Request!

This PR adds --additional-properties option to backstage-repo-tools package schema openapi generate command. The list of config options that can be passed with --additional-properties can be found here.

✔️ Checklist

  • A changeset describing the change and affected packages. (more info)
  • Added or updated documentation
  • Tests for new functionality and regression tests for bug fixes
  • Screenshots attached (for UI changes)
  • All your commits have a Signed-off-by line in the message. (more info)

@nurbaysymbat
repo-tools: add additional properties to generate command
8721a02 
Signed-off-by: Symbat Nurbay <symbat01011996@gmail.com>
@backstage-goalie
Copy link
Contributor

backstage-goalie bot commented May 16, 2024 •
edited

Changed Packages

Package Name Package Path Changeset Bump Current Version
@backstage/repo-tools packages/repo-tools patch v0.9.1-next.0

@nurbaysymbat nurbaysymbat marked this pull request as ready for review May 16, 2024 14:04
@nurbaysymbat nurbaysymbat requested review from a team as code owners May 16, 2024 14:04
aramissennyeydd
aramissennyeydd requested changes May 16, 2024
View reviewed changes
Copy link
Contributor

@aramissennyeydd aramissennyeydd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 Thanks for this! One small adjustment but otherwise looks good.

packages/repo-tools/src/commands/index.ts Outdated Show resolved Hide resolved
@nurbaysymbat
repo-tools: rename --additional-properties to --client-additional-pro…
0714031 
…perties

Signed-off-by: Symbat Nurbay <symbat01011996@gmail.com>
@nurbaysymbat
repo-tools: change changeset
70b51b2 
Signed-off-by: Symbat Nurbay <symbat01011996@gmail.com>
aramissennyeydd
aramissennyeydd approved these changes May 21, 2024
View reviewed changes
Copy link
Contributor

@aramissennyeydd aramissennyeydd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit: 🚢

@benjdlambert
Update strong-moose-work.md
11540f4 
Signed-off-by: Ben Lambert <ben@blam.sh>
benjdlambert
benjdlambert approved these changes May 27, 2024
View reviewed changes
Copy link
Member

@benjdlambert benjdlambert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Just updated the changeset a little bit to keep the changlog clean, and this isn't a required option, so it's not a breaking change, so moved it down to patch 🎉

@benjdlambert benjdlambert merged commit 72ee582 into backstage:master May 27, 2024
28 checks passed
@github-actions GitHub Actions
Copy link
Contributor

Thank you for contributing to Backstage! The changes in this pull request will be part of the 1.28.0 release, scheduled for Tue, 18 Jun 2024.

@github-actions GitHub Actions
Copy link
Contributor

Uffizzi Cluster pr-24810 was deleted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benjdlambert benjdlambert benjdlambert approved these changes

@aramissennyeydd aramissennyeydd aramissennyeydd approved these changes

@camilaibs camilaibs Awaiting requested review from camilaibs camilaibs is a code owner automatically assigned from backstage/reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nurbaysymbat @benjdlambert @aramissennyeydd