Required multiselects and timezone configuration during cli install #9798
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghermans
changed the title
amit-webkul
requested changes
May 23, 2024
| @@ -427,6 +448,7 @@ protected function allowedChoice(string $question, array $choices) | |||
| $selectedValues = multiselect( | |||
| label: $question, | |||
| options: array_values($choices), | |||
| required: true, | |||
There was a problem hiding this comment.
If no options are selected in the "Allowed Currencies" and "Allowed Locales" sections, the default currency and locales will be automatically applied. Therefore, it is not necessary to make this a required step. If there are specific reasons for making this mandatory, please provide an explanation.
Comment on lines
+181
to
+184
| $defaultTimezone = $this->updateEnvSuggest( | ||
| 'APP_TIMEZONE', | ||
| date_default_timezone_get() | ||
| 'Please select the application timezone', | ||
| $timezones |
There was a problem hiding this comment.
We can manage this action using the existing updateEnvChoice method. Adding a new method for a single action is unnecessary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR makes the multiselect for Currencies and Locales required during the installation.
It also gives the site owner the option to configure the timezone
Branch Selection