Qianfan with http proxy #495
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Azure99
reviewed
Apr 29, 2024
| @@ -52,11 +53,29 @@ public Qianfan(String type, String accessKey, String secretKey) { | |||
| this.client = new QianfanClient(type, accessKey, secretKey); | |||
| } | |||
|
|
|||
|
|
|||
| public Qianfan(ProxyConfig proxyConfig) { | |||
There was a problem hiding this comment.
目前的涉及中，只有鉴权从constructor中传入，其它配置均在Qianfan的实例上调用setXXXConfig实现。这是为了避免后续Config太多，造成重载太多。
| import java.util.LinkedHashMap; | ||
| import java.util.Map; | ||
|
|
||
| public class HttpProxyClient { |
There was a problem hiding this comment.
HttpClient是公用的，可以考虑使用HttpClientContext在Request维度传入代理信息，而不是在Client上设置
Azure99
reviewed
Apr 29, 2024
| this.client = new QianfanClient(proxyConfig); | ||
| } | ||
|
|
||
| public Qianfan(String accessKey, String secretKey,ProxyConfig proxyConfig) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.