Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature constructor forgets everything when variable change in upstream widgets #5636

Open
clsandt opened this issue Oct 8, 2021 · 3 comments · May be fixed by #6801
Open

Feature constructor forgets everything when variable change in upstream widgets #5636

clsandt opened this issue Oct 8, 2021 · 3 comments · May be fixed by #6801
Assignees
Labels
bug A bug confirmed by the core team

Comments

@clsandt
Copy link

clsandt commented Oct 8, 2021

The feature constructor widget deletes all the new variable definitions when you change variables in upstream widgets, it deletes even new variables that do not use the changed variables.

For example, I use an Integrate spectra widget to create variables that I then ratio against each other in the Feature constructor. If I modify or delete one of the integrated variables in teh upstream widget, all variables creatd in the Feature constructor disappear, even those that do not use the modified variable.

I uploaded a worflow that can be used to reproduce the bug. It uses data from the repository accessed with the Dataset widget.

I use Orange '3.29.3' in Quasar 1.2 on Windows X
Quasar was installed from the installer.
Bug report feature constructor workflow.zip

Thanks

@clsandt clsandt added the bug report Bug is reported by user, not yet confirmed by the core team label Oct 8, 2021
@ajdapretnar
Copy link
Contributor

Example workflow:
File (iris) - Select Column (do nothing yet) - Feature Constructor.
Create two new variables, one from sepal length and one from sepal width (say sepal length + 1).
Now remove sepal width from attributes with Select Columns.
The entire Feature Constructor becomes empty.
It should keep sepal length since it is still in the domain.

@janezd janezd added bug A bug confirmed by the core team and removed bug report Bug is reported by user, not yet confirmed by the core team labels Oct 22, 2021
@janezd
Copy link
Contributor

janezd commented Oct 22, 2021

Discussion: we will experiment with Orange without contexts (that is, a context history of size 1).

@ereztison
Copy link
Sponsor

+1
Still happens v3.36.1, sadly it makes using the widget very problematic in cases where reloading of source data is needed.

@janezd janezd self-assigned this Dec 8, 2023
@ales-erjavec ales-erjavec linked a pull request May 10, 2024 that will close this issue
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A bug confirmed by the core team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants