Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Formula: Remove context settings #6801

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ales-erjavec
Copy link
Contributor

@ales-erjavec ales-erjavec commented May 10, 2024

Issue

Fixes: gh-5636

Description of changes

Remove context settings from Formula widget.

Includes
  • Code changes
  • Tests
  • Documentation

Copy link

codecov bot commented May 10, 2024

Codecov Report

Attention: Patch coverage is 95.45455% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 88.24%. Comparing base (ce27d18) to head (740b823).

Current head 740b823 differs from pull request most recent head 8cbf2dc

Please upload reports for the commit 8cbf2dc to get more accurate results.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6801      +/-   ##
==========================================
- Coverage   88.24%   88.24%   -0.01%     
==========================================
  Files         327      327              
  Lines       71342    71331      -11     
==========================================
- Hits        62954    62944      -10     
+ Misses       8388     8387       -1     

@ales-erjavec ales-erjavec force-pushed the feature-constructor-no-context branch 3 times, most recently from 740b823 to 5dc34aa Compare May 31, 2024 07:48
@ales-erjavec ales-erjavec marked this pull request as ready for review May 31, 2024 08:17
@ales-erjavec ales-erjavec force-pushed the feature-constructor-no-context branch from 5dc34aa to 8cbf2dc Compare May 31, 2024 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature constructor forgets everything when variable change in upstream widgets
1 participant